Fix gradient issue (#113)

* Fix legend items * Increase visual version --------- Co-authored-by: Iuliia Kulagina <[email protected]>
microsoft · Oct 14, 2024 · f222e1d · f222e1d
1 parent 4646416
commit f222e1d
Show file tree

Hide file tree

Showing 5 changed files with 24 additions and 19 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,4 +1,7 @@
 
+## 3.0.5.0
+* Fix bug with empty columns gradient when legend is disabled
+
 ## 3.0.4.0
 * Use selectionManager instead of interactivity utils
 * Add interactivity to legend

diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "powerbi-visuals-tornadochart",
-  "version": "3.0.4.0",
+  "version": "3.0.5.0",
   "author": {
     "name": "Microsoft",
     "email": "[email protected]"

diff --git a/pbiviz.json b/pbiviz.json
@@ -1,10 +1,10 @@
 {
   "visual": {
     "name": "TornadoChart",
-    "displayName": "Tornado 3.0.4.0",
+    "displayName": "Tornado 3.0.5.0",
     "guid": "TornadoChart1452517688218",
     "visualClassName": "TornadoChart",
-    "version": "3.0.4.0",
+    "version": "3.0.5.0",
     "description": "A bar chart with category values listed vertically. Use for comparing the relative importance of a variable between two distinct groups.",
     "supportUrl": "https://community.powerbi.com",
     "gitHubUrl": "https://github.com/Microsoft/PowerBI-visuals-Tornado"

diff --git a/src/TornadoChart.ts b/src/TornadoChart.ts
@@ -1029,50 +1029,52 @@ export class TornadoChart implements IVisual {
     }
 
     private renderLegend(): void {
-        const formattingSettings: TornadoChartSettingsModel = this.formattingSettings;
-        if (formattingSettings.legendCardSettings.show.value) {
+        const legendSettings: LegendCardSettings = this.formattingSettings.legendCardSettings;
+        if (legendSettings.show.value) {
 
             const legend: LegendData = this.dataView.legend;
             if (!legend) {
                 return;
             }
 
-            const legendLabelsColor: string = formattingSettings.legendCardSettings.labelColor.value.value;
+            const legendLabelsColor: string = legendSettings.labelColor.value.value;
             const legendData: LegendData = {
                 title: legend.title,
                 dataPoints: legend.dataPoints,
-                fontSize: formattingSettings.legendCardSettings.font.fontSize.value,
-                fontFamily: formattingSettings.legendCardSettings.font.fontFamily.value,
+                fontSize: legendSettings.font.fontSize.value,
+                fontFamily: legendSettings.font.fontFamily.value,
                 labelColor: this.colorHelper.isHighContrast ? this.colorHelper.getHighContrastColor("foreground", legendLabelsColor) : legendLabelsColor
             };
 
             if (this.dataView.legendObjectProperties) {
                 LegendDataModule.update(legendData, this.dataView.legendObjectProperties);
 
-                const position = this.formattingSettings.legendCardSettings.positionDropdown.value.value;
+                const position = legendSettings.positionDropdown.value.value;
 
                 if (position) {
                     this.legend.changeOrientation(LegendPosition[position]);
                 }
             }
 
             this.legend.drawLegend(legendData, { ...this.viewport });
-            this.legendItems = this.legendSelection.selectAll(TornadoChart.LegendItemSelector.selectorName);
-
-            this.legendSelection.selectAll("text")
-                .style("font-weight",  () => this.formattingSettings.legendCardSettings.font.bold.value ? "bold" : "normal")
-                .style("font-style",  () => this.formattingSettings.legendCardSettings.font.italic.value ? "italic" : "normal")
-                .style("text-decoration", () => this.formattingSettings.legendCardSettings.font.underline.value ? "underline" : "none");
 
-            if (legendData.dataPoints.length > 0 && formattingSettings.legendCardSettings.show.value) {
+            if (legendData.dataPoints.length > 0 && legendSettings.show.value) {
                 this.updateViewport();
             }
         }
         else {
             this.legend.reset();
             this.legend.drawLegend({ dataPoints: [] }, this.viewport);
         }
-        TornadoChart.SetPositionsDependingOnLegend(this.rootContainer, formattingSettings.legendCardSettings, this.legend);
+
+        this.legendItems = this.legendSelection.selectAll(TornadoChart.LegendItemSelector.selectorName);
+
+        this.legendSelection.selectAll("text")
+            .style("font-weight",  () => legendSettings.font.bold.value ? "bold" : "normal")
+            .style("font-style",  () => legendSettings.font.italic.value ? "italic" : "normal")
+            .style("text-decoration", () => legendSettings.font.underline.value ? "underline" : "none");
+
+        TornadoChart.SetPositionsDependingOnLegend(this.rootContainer, legendSettings, this.legend);
     }
 
     public static SetPositionsDependingOnLegend(chartArea: HTMLElement, legendSettings: LegendCardSettings, legend: ILegend): void{