-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Copilot No. Series] Number series copilot #764
Open
DmitryKatson
wants to merge
63
commits into
microsoft:main
Choose a base branch
from
DmitryKatson:Number-Series-Copilot
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
63 commits
Select commit
Hold shift + click to select a range
44ac608
[DRAFT] Add No. Series Copilot app components and capabilities (witho…
DmitryKatson 0e90f92
Changed page and table numbers
DmitryKatson 398193b
[DRAFT] Adding Azure OpenAI Tools Calling API support
DmitryKatson 535771e
[DRAFT] Refactor tool functions and processing, and update UI elements.
DmitryKatson ccb2680
Add ToolCalls to the chat message history
DmitryKatson 38ff86e
Adding tools support from AI system module
DmitryKatson 0d9569f
Add support of JSON mode
DmitryKatson 573e296
[DRAFT] Add support for json output
DmitryKatson cb6917f
[DRAFT] Refactor tool invocation logic and update prompt formats
DmitryKatson 48395f5
[DRAFT] Moving from GPT-4 to GPT-3.5 and refactor prompts
DmitryKatson 229d542
Add Json functionality for working with JSON data
DmitryKatson 13fcfc9
[DRAFT] Show generated No. Series in the prompt dialoge
DmitryKatson 73e5041
Adding Area to the prompt so that copilot have better "feeling" on th…
DmitryKatson 1cf9105
Tools message parsing and tool extraction logic
DmitryKatson 2e4f32e
[DRAFT] Refactor tool parsing to utilize dedicated method
DmitryKatson b4662c2
Split tools responses into chunks and call each chunk individually, i…
DmitryKatson 71676f7
[DRAFT] Refactor NoSeriesCopilotImpl to Chunk Tables Processing
DmitryKatson 03187d0
[DRAFT] Refactor prompt generation code to retrieve tool 1 patterns a…
DmitryKatson a5e294b
[DRAFT] Tool 1 prompt refactoring for better speed
DmitryKatson 40f548a
[DRAFT] Refactor JSON manipulation and introduce functionality to han…
DmitryKatson 2360e7c
Refactor No. Series Copilot prompts
DmitryKatson e5d9fe5
Refactor JSON handling methods for improved readability and modularity
DmitryKatson 0aea640
[DRAFT] Adding custom pattern instructions to the prompt
DmitryKatson debd0e5
Added a custom label to prompt list for user-defined number patterns.
DmitryKatson 95cdbd0
Remove duplicate NoSeriesCopilotInstaller and wrong namespace from No…
DmitryKatson 6461446
Implement scenario when user asks to generate number series for the s…
DmitryKatson bdf8bf8
Implemented scenario when user specified entity and pattern in the qu…
DmitryKatson 6546377
New methods to work with existing number series tables.
DmitryKatson 8387ea7
Merge branch 'microsoft:main' into Number-Series-Copilot
DmitryKatson 5e56313
Merge branch 'microsoft:main' into Number-Series-Copilot
DmitryKatson f13948b
Filter No Series fields on the setup fields by the No Series rtable r…
DmitryKatson 62170b1
Refactor system and tools prompts, implement tool selection retry log…
DmitryKatson b2fede8
Refactor error handling and prompt generation logic
DmitryKatson da1da9c
Update platform version, add instructional text, and modify prompt gu…
DmitryKatson 6447fa1
Refactor No Series Proposal page to clarify actions and labels
DmitryKatson da6d9f4
Adding user prompts, placeholder and refactor custom patterns prompts.
DmitryKatson 525be72
Enable editing of No Series Proposals: delete/modify
DmitryKatson 8050a7e
Refactor tools calling into separate modules.
DmitryKatson c07ca62
Refactor prompt guide actions for clarity and consistency
DmitryKatson 63f0770
Update action captions on the "No Series Proposal" page to use "Creat…
DmitryKatson 874c138
Merge branch 'Number-Series-Copilot' of https://github.com/DmitryKats…
DmitryKatson 7d65f55
Refactor codeunits: update codeunit number and redefine function
DmitryKatson 3d0f9af
Refactor No Series Copilot to make compatable with the lateast AOAI m…
DmitryKatson 111caf2
fix conditional compilation directive, as was not merged correctly
DmitryKatson 39312b3
Refactor NoSeriesCopilot code to utilize GetNoSeriesSuggestions to en…
DmitryKatson 79f87d2
Refactor code for dynamic removal of multiple text parts
DmitryKatson 332eb95
Synch with PR #719
DmitryKatson 3a9c538
Merge branch 'Number-Series-Copilot' of https://github.com/DmitryKats…
DmitryKatson 07124f5
Fix CodeCop issues and some code review comments.
JesperSchulz 2156136
Make build succeed.
JesperSchulz c2726e4
Merge branch 'microsoft:main' into Number-Series-Copilot
DmitryKatson 89d64c8
Refactor tool prompt generation in No Series Copilot codeunit: use ad…
DmitryKatson 2b2b4bf
Refactor notification handling and add chat completion error handling.
DmitryKatson 21211e2
Refactor setup table retrieval and validation logic.
DmitryKatson 4e99190
Solving casing warning
DmitryKatson 094f75c
Add feature name label for Number Series with AI
DmitryKatson 534327a
Refactor RandIntInRange function parameters
DmitryKatson 5278711
Fix label casing and parameter names
DmitryKatson f50cbc0
Changed variable names
DmitryKatson 6d3b89a
wait for the next AI call only if next exist. Exit as early as possible
DmitryKatson dfa953a
Resolved [NonDebuggable] and SecretText
DmitryKatson c97d811
Refine logic for removing last character in AreasText
DmitryKatson 9f55606
Fix CodeCop issues.
JesperSchulz File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
23 changes: 23 additions & 0 deletions
23
...siness Foundation/App/NoSeriesCopilot/Permissions/NoSeriesCopilotObjects.permissionset.al
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,23 @@ | ||
// ------------------------------------------------------------------------------------------------ | ||
// Copyright (c) Microsoft Corporation. All rights reserved. | ||
// Licensed under the MIT License. See License.txt in the project root for license information. | ||
// ------------------------------------------------------------------------------------------------ | ||
|
||
namespace Microsoft.Foundation.NoSeries; | ||
|
||
permissionset 330 "No. Series Copilot - Objects" | ||
{ | ||
Access = Internal; | ||
Assignable = false; | ||
Permissions = | ||
codeunit "No. Series Cop. Add Intent"=X, | ||
codeunit "No. Series Cop. Change Intent"=X, | ||
codeunit "No. Series Cop. Tools Impl."=X, | ||
codeunit "No. Series Copilot Impl."=X, | ||
codeunit "No. Series Copilot Install"=X, | ||
codeunit "No. Series Copilot Register"=X, | ||
codeunit "No. Series Copilot Upgr. Tags"=X, | ||
page "No. Series Copilot Setup"=X, | ||
tabledata "No. Series Copilot Setup"=RIMD; | ||
|
||
} |
Empty file.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,52 @@ | ||
{ | ||
"id": "7efce506-def2-4195-9d1e-bc538e729242", | ||
"name": "No. Series Copilot", | ||
"publisher": "Microsoft", | ||
"brief": "", | ||
"description": "", | ||
"version": "25.0.0.0", | ||
"privacyStatement": "https://go.microsoft.com/fwlink/?linkid=724009", | ||
"EULA": "https://go.microsoft.com/fwlink/?linkid=2009120", | ||
"help": "https://go.microsoft.com/fwlink/?linkid=2103698", | ||
"url": "https://go.microsoft.com/fwlink/?linkid=724011", | ||
"logo": "", | ||
"dependencies": [ | ||
{ | ||
"id": "63ca2fa4-4f03-4f2b-a480-172fef340d3f", | ||
"name": "System Application", | ||
"publisher": "Microsoft", | ||
"version": "25.0.0.0" | ||
}, | ||
{ | ||
"id": "d098b816-22fd-477f-9602-9122f5465527", | ||
"name": "No. Series", | ||
"publisher": "Microsoft", | ||
"version": "25.0.0.0" | ||
} | ||
], | ||
"internalsVisibleTo": [ | ||
], | ||
"screenshots": [ | ||
|
||
], | ||
"platform": "25.0.0.0", | ||
"target": "OnPrem", | ||
"idRanges": [ | ||
{ | ||
"from": 1, | ||
"to": 9999 | ||
} | ||
], | ||
"features": [ | ||
"TranslationFile", | ||
"GenerateCaptions", | ||
"NoImplicitWith", | ||
"NoPromotedActionProperties" | ||
], | ||
"resourceExposurePolicy": { | ||
"allowDebugging": true, | ||
"allowDownloadingSource": true, | ||
"includeSourceInSymbolFile": true | ||
}, | ||
"contextSensitiveHelpUrl": "https://learn.microsoft.com/dynamics365/business-central/" | ||
} |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the *objects permission sets should not contain tabledata. These permissionsets exist as building blocks for those customers that do not use * = X in their permissionsets which means they need a way to run the internal objects, and this is it.
The tabledata permissions should be split by usage scenario, but the defaults we use are Read, View, Edit or Admin
where not all are required and we typically have Read + 1 or two more. Each subsequent level includes the previous. As some of these might seem ambiguous, here's how I see them:
Read = only r or R.
View = ability to directly view the data on screen but no direct edit ability (optional indirect imd).
Edit = direct edit on pages
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, this one is my bad. I had the permission set generated to please CodeCop, and then I accidentally checked in the permission set before actually getting this right. I will revisit the permissions!