Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review AI Test Toolkit Changes #1472

Closed
wants to merge 2 commits into from
Closed

Review AI Test Toolkit Changes #1472

wants to merge 2 commits into from

Conversation

StefanMaron
Copy link

In this PR I did address (hopfully) most of the comments I put in the pull request.
Its mostly guideline changes and readability improvements.

@StefanMaron StefanMaron requested a review from a team as a code owner July 3, 2024 08:03
@github-actions github-actions bot added AL: Tools From Fork Pull request is coming from a fork labels Jul 3, 2024
@StefanMaron StefanMaron mentioned this pull request Jul 3, 2024
Open
nikolakukrika
nikolakukrika approved these changes Jul 3, 2024
View reviewed changes
Copy link

@nikolakukrika nikolakukrika left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for doing this change. Could you update the minor comments?
If not we will fix it after it is merged. Feel free to merge it when you can.

src/Tools/AI Test Toolkit/src/API/AITLogEntryAPI.Page.al Outdated Show resolved Hide resolved
src/Tools/AI Test Toolkit/src/Logs/AITLogEntry.Table.al Outdated Show resolved Hide resolved
src/Tools/AI Test Toolkit/src/Logs/AITTestMethodLinesCompare.Page.al Outdated Show resolved Hide resolved
src/Tools/AI Test Toolkit/src/Logs/AITTestSuiteCompare.Page.al Outdated Show resolved Hide resolved
src/Tools/AI Test Toolkit/src/TestSuite/AITTestMethodLine.Table.al Outdated Show resolved Hide resolved
src/Tools/AI Test Toolkit/src/TestSuite/AITTestSuite.Table.al Outdated Show resolved Hide resolved
src/Tools/Test Framework/Test Runner/src/TestMethodLine.Table.al Show resolved Hide resolved
@JesperSchulz JesperSchulz added the Linked Issue is linked to a Azure Boards work item label Jul 3, 2024
@StefanMaron
Copy link
Author

@nikolakukrika I can not merge it myself, but I did the changes

@nikolakukrika nikolakukrika reopened this Jul 5, 2024
@nikolakukrika
Copy link

We had conflicts, I have resolved them in a different branch and merged.
Thanks a lot for the review and the fixes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Aleyenda Aleyenda Aleyenda approved these changes

@nikolakukrika nikolakukrika nikolakukrika approved these changes

Assignees
No one assigned
Labels
AL: Tools From Fork Pull request is coming from a fork Linked Issue is linked to a Azure Boards work item
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@StefanMaron @nikolakukrika @Aleyenda @JesperSchulz