-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add VS Code Request Manager module #1410
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…te/brobledodiaz/add-open-from-git-action
…te/brobledodiaz/add-open-from-git-action
…te/brobledodiaz/add-open-from-git-action
SBalslev
previously approved these changes
Jun 28, 2024
grobyns
reviewed
Jun 28, 2024
src/System Application/App/Vs Code Request Management/src/VSCodeRequestManagement.Codeunit.al
Outdated
Show resolved
Hide resolved
grobyns
reviewed
Jun 28, 2024
src/System Application/App/Vs Code Request Management/src/VSCodeRequestManagement.Codeunit.al
Outdated
Show resolved
Hide resolved
grobyns
reviewed
Jun 28, 2024
src/System Application/App/Extension Management/src/ExtensionManagement.Page.al
Outdated
Show resolved
Hide resolved
grobyns
previously requested changes
Jun 28, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please follow the facade/impl. pattern we use for modules
krupybalu
reviewed
Jul 1, 2024
src/System Application/App/Vs Code Request Management/src/VSCodeRequestManagement.Codeunit.al
Outdated
Show resolved
Hide resolved
JesperSchulz
requested changes
Jul 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add XML docs to public procedures. Then I'll approve!
src/System Application/App/VS Code Integration/src/VsCodeIntegration.Codeunit.al
Outdated
Show resolved
Hide resolved
JesperSchulz
previously approved these changes
Jul 4, 2024
JesperSchulz
reviewed
Jul 4, 2024
src/System Application/App/Extension Management/src/ExtensionManagement.Page.al
Outdated
Show resolved
Hide resolved
JesperSchulz
previously approved these changes
Jul 4, 2024
darjoo
reviewed
Jul 5, 2024
src/System Application/App/VS Code Integration/src/VsCodeIntegration.Codeunit.al
Show resolved
Hide resolved
src/System Application/App/VS Code Integration/src/VsCodeIntegration.Codeunit.al
Show resolved
Hide resolved
src/System Application/App/Extension Management/src/ExtensionManagement.Page.al
Show resolved
Hide resolved
darjoo
approved these changes
Jul 5, 2024
SBalslev
approved these changes
Jul 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The VS Code Request Manager module is used to embed requests in the Web Client (Page Inspector, Extension Management for now) to the AL extension in VS Code to navigate to an object's definition, initiate a debugging session or get the source code of an extension from Git.
Work Item(s)
Fixes AB#536537