Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add VS Code Request Manager module #1410

Merged
merged 25 commits into from
Jul 5, 2024

Conversation

blrobl
Copy link
Contributor

@blrobl blrobl commented Jun 26, 2024

Summary

The VS Code Request Manager module is used to embed requests in the Web Client (Page Inspector, Extension Management for now) to the AL extension in VS Code to navigate to an object's definition, initiate a debugging session or get the source code of an extension from Git.

Work Item(s)

Fixes AB#536537

@blrobl blrobl requested a review from krupybalu June 26, 2024 15:21
@blrobl blrobl marked this pull request as ready for review June 28, 2024 09:23
@blrobl blrobl requested review from a team as code owners June 28, 2024 09:23
SBalslev
SBalslev previously approved these changes Jun 28, 2024
Copy link
Contributor

@grobyns grobyns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please follow the facade/impl. pattern we use for modules

@blrobl blrobl requested a review from grobyns July 2, 2024 15:13
@blrobl blrobl removed the request for review from grobyns July 4, 2024 08:28
Copy link
Contributor

@JesperSchulz JesperSchulz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add XML docs to public procedures. Then I'll approve!

JesperSchulz
JesperSchulz previously approved these changes Jul 4, 2024
JesperSchulz
JesperSchulz previously approved these changes Jul 4, 2024
@blrobl blrobl merged commit cbff2d0 into main Jul 5, 2024
25 checks passed
@blrobl blrobl deleted the private/brobledodiaz/add-open-from-git-action branch July 5, 2024 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants