Fix percentiles gauges in Dropwizard-based implementations (fixes #331)

micrometer-metrics · Jan 5, 2018 · 1b41f8b · 1b41f8b
1 parent d477d06
commit 1b41f8b
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 6 deletions.
diff --git a/...tions/micrometer-registry-atlas/src/main/java/io/micrometer/atlas/AtlasMeterRegistry.java b/...tions/micrometer-registry-atlas/src/main/java/io/micrometer/atlas/AtlasMeterRegistry.java
@@ -110,7 +110,7 @@ protected io.micrometer.core.instrument.DistributionSummary newDistributionSumma
 
         for (double percentile : histogramConfig.getPercentiles()) {
             gauge(id.getName(), Tags.concat(getConventionTags(id), "percentile", percentileFormat.format(percentile)),
-                percentile, summary::percentile);
+                summary, s -> s.percentile(percentile));
         }
 
         return summary;
@@ -133,7 +133,7 @@ protected Timer newTimer(Meter.Id id, HistogramConfig histogramConfig, PauseDete
 
         for (double percentile : histogramConfig.getPercentiles()) {
             gauge(id.getName(), Tags.concat(getConventionTags(id), "percentile", percentileFormat.format(percentile)),
-                percentile, p -> timer.percentile(p, TimeUnit.SECONDS));
+                timer, t -> t.percentile(percentile, TimeUnit.SECONDS));
         }
 
         return timer;

diff --git a/...-core/src/main/java/io/micrometer/core/instrument/dropwizard/DropwizardMeterRegistry.java b/...-core/src/main/java/io/micrometer/core/instrument/dropwizard/DropwizardMeterRegistry.java
@@ -78,7 +78,7 @@ protected Timer newTimer(Meter.Id id, HistogramConfig histogramConfig, PauseDete
 
         for (double percentile : histogramConfig.getPercentiles()) {
             gauge(id.getName(), Tags.concat(getConventionTags(id), "percentile", percentileFormat.format(percentile)),
-                percentile, p -> timer.percentile(p, getBaseTimeUnit()));
+                timer, t -> t.percentile(percentile, getBaseTimeUnit()));
         }
 
         if (histogramConfig.isPublishingHistogram()) {
@@ -97,7 +97,7 @@ protected DistributionSummary newDistributionSummary(Meter.Id id, HistogramConfi
 
         for (double percentile : histogramConfig.getPercentiles()) {
             gauge(id.getName(), Tags.concat(getConventionTags(id), "percentile", percentileFormat.format(percentile)),
-                percentile, summary::percentile);
+                summary, s -> summary.percentile(percentile));
         }
 
         if (histogramConfig.isPublishingHistogram()) {

diff --git a/micrometer-core/src/main/java/io/micrometer/core/instrument/simple/SimpleMeterRegistry.java b/micrometer-core/src/main/java/io/micrometer/core/instrument/simple/SimpleMeterRegistry.java
@@ -69,7 +69,7 @@ protected DistributionSummary newDistributionSummary(Meter.Id id, HistogramConfi
 
         for (double percentile : histogramConfig.getPercentiles()) {
             gauge(id.getName(), Tags.concat(getConventionTags(id), "percentile", percentileFormat.format(percentile)),
-                percentile, summary::percentile);
+                summary, s -> summary.percentile(percentile));
         }
 
         if(histogramConfig.isPublishingHistogram()) {
@@ -106,7 +106,7 @@ protected Timer newTimer(Meter.Id id, HistogramConfig histogramConfig, PauseDete
 
         for (double percentile : histogramConfig.getPercentiles()) {
             gauge(id.getName(), Tags.concat(getConventionTags(id), "percentile", percentileFormat.format(percentile)),
-                percentile, p -> timer.percentile(p, getBaseTimeUnit()));
+                timer, t -> t.percentile(percentile, getBaseTimeUnit()));
         }
 
         if(histogramConfig.isPublishingHistogram()) {