This repository has been archived by the owner on Jan 13, 2023. It is now read-only.
Use user env for shell scripts #141
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josephmilla
changed the title
|
@josephmilla This really cleans up the shell script, thanks!. What are your thoughts though on using a Makefile instead. I generally prefer Makefiles to shell scripts but am not overly concerned yet at this point. We then combine the build and release scripts into a single tool that is easily put into a CD/CI pipeline and just create multiple targets for each OS or action. |
|
@josephmilla I merged this in tonight for the sake of it as the code makes a lot of improvements and I don't have the time to write a makefile at the moment. Thanks for this! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.