add from_dict() wrappers to spl/token/instructions.py

[azerv1]

related #344

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.18%. Comparing base (a5434bc) to head (138ca9b).

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #478      +/-   ##
==========================================
+ Coverage   92.00%   92.18%   +0.17%     
==========================================
  Files          27       27              
  Lines        2226     2277      +51     
==========================================
+ Hits         2048     2099      +51     
  Misses        178      178              

[michaelhly]

Suggested change

	@classmethod
	def from_dict(cls, params: dict) -> "AuthorityType":
	"""AuthorityType dict wrapper."""
	return cls(**params)

This one is not necessary as it is an Enum

[michaelhly]

Would you mind updating the corresponding unit tests here?

solana-py/tests/unit/test_spl_token_instructions.py

Line 10 in 3d76045

def test_initialize_mint(stubbed_sender):

[kevinheavey]

What does this achieve? Can't the user already call ApproveParams(**params)?

[azerv1]

you are right. I falsely assumed that you were asking for something like python coding style convention. But regarding #344 , can you explain what more pythonic is?