-
Notifications
You must be signed in to change notification settings - Fork 292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add stake program functionality #345
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #345 +/- ##
==========================================
- Coverage 89.69% 89.67% -0.03%
==========================================
Files 27 31 +4
Lines 2193 2324 +131
==========================================
+ Hits 1967 2084 +117
- Misses 226 240 +14 |
@mindrunner can you fix the linter issues and write a few integration tests that cover the new code? |
yeap, already on it. didn't find the time yet |
Looking at the tests, it seems like comparing my tx with Where does |
Yes |
@mindrunner i'm trying to incorporate your code, but am having an issue when trying to use |
Are you refering to Just generate a keypair and pass in the public part and you should be fine! :) |
Does it not require an owner? When you create a token account it has to be attached to an owner, so I would assume this would be the same or a similar system. |
As far as I know, those kind of accounts do not have an ownership of that kind. You provide an authorized keypair instead. This private key will be the one having the stake in custody. I think the Solana Stackexchange would probably be the better place to ask such questions :) |
Replacement for:
#129