Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed behaviour for tags in titles and file properties #1017

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

bpthecodeman
Copy link

@bpthecodeman bpthecodeman commented Jul 14, 2024

What has been done:

  • Added settings for adding the tags in title and/or porperties.
  • Modified New note from card function to not remove the tags from card title
  • Modified New note from card to use the settings to either leave the tags in the note title or not
  • Modified New note from card to use the settings to either add the tags to note properties or not.

Behaviour after change:

Current Settings Action Picture
Tag in title: Off
Tag in properties: Off
Card with no tags image
Tag in title: Off
Tag in properties: Off
Card with 1 tag image
Tag in title: Off
Tag in properties: Off
Card with multiple tags image
Tag in title: On
Tag in properties: Off
Card with no tags image
Tag in title: On
Tag in properties: Off
Card with 1 tag image
Tag in title: On
Tag in properties: Off
Card with multiple tags image
Tag in title: Off
Tag in properties: On
Card with no tags image
Tag in title: Off
Tag in properties: On
Card with 1 tag image
Tag in title: Off
Tag in properties: On
Card with multiple tags image
Tag in title: On
Tag in properties: On
Card with no tags image
Tag in title: On
Tag in properties: On
Card with 1 tag image
Tag in title: On
Tag in properties: On
Card with multiple tags image

Closes #1016

Added settings for adding the tags in title and/or porperties. Modified the 'New note from card' function to not remove the tags from card title, to use the settings to either leave the tags in the note title or not and use the settings to either add the tags to note properties or not.
@Number1awa
Copy link

Is there any movement on this PR? This PR was created back in July.

@bpthecodeman
Copy link
Author

I am waiting for someone to review it and merge it. I don't think that there is something left for me to do.

@OussDeCouette
Copy link

Hi @bpthecodeman, I'm not experienced with github and typescript/javascript. Can you make a release of it so I can try it on my own obsidian ? Thanks !

@i-knock
Copy link

i-knock commented Dec 18, 2024

Are there any updates regarding merging this PR? I am not experienced with typescript/javascript either, but the problem is still there in the latest release 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Tag removed and used in the note title when creating new note from task
4 participants