Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement temp file #550

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

FelipeLema
Copy link
Contributor

fixes #235

@FelipeLema
Copy link
Contributor Author

missing tests

@FelipeLema FelipeLema marked this pull request as ready for review March 7, 2024 17:06
@FelipeLema
Copy link
Contributor Author

PR ready, although I'm unsure why 0.6.1 is failing

@FelipeLema
Copy link
Contributor Author

FelipeLema commented Mar 7, 2024

oh, so nvim_create_autocmd did not exist ... not sure if it's worth re-doing using vimscript, since it's a (lua / luv) timer object that needs to be handled in there

implemented using module variable

@dante0624
Copy link
Contributor

@FelipeLema I'm new to this plugin and don't fully understand it, but right now it looks like your changes are unused. Before merging this, wouldn't some type of modification be needed to the init.lua file's M.lint function? It would need to call your temp_filepath function, actually create the temp file, fill it with the contents of the current buffer, and then append the filename to the args table (in M.lint)?

Also, the creation of the temp file and filling it with the contents of the current buffer could all happen within your temp_file.lua file. Maybe a new function or two could be created for that.

I would be happy to work on this with you by the way. Let me know what you think

@FelipeLema
Copy link
Contributor Author

FelipeLema commented Jun 17, 2024

hey @dante0624

the scope of this PR is within #235 and is meant to provide a tool for shadow files when needed. it is not my intention to replace default implementation of this plugin, but rather extend it to cover previously ignored usecases

filling the tempfile could be done in different ways. I explicitly left that out to keep this PR short

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature request: shadow file / temporary file as when stdin = false
2 participants