Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing useNativeDriver warning #121

Closed
wants to merge 4 commits into from
Closed

Fixing useNativeDriver warning #121

wants to merge 4 commits into from

Conversation

mfrachet
Copy link
Owner

Should fix #120

@nelsonprsousa
Copy link

Is is possible to set useNativeDriver to true? Without useNativeDriver, all the work is done on the JS thread, causing frame drops in our applications. I know there are limitations when to use useNativeDriver, but maybe we could improve this somehow 🤷‍♂️

Thanks for your work 🚀

@mfrachet
Copy link
Owner Author

I can't do this on every single animations since useNativeDriver works only for transition and opacity things :/

There's already an issue to move the animation on the main thread instead #99 but I honestly don't have time to rework this for now :/

@nelsonprsousa
Copy link

No worries, maybe someone with enough experience can take a look 🚀

Thanks for fixing!

@nelsonprsousa
Copy link

@mfrachet I think we can merge to get rid of this warning. Maybe in the future someone can have an idea to avoid block the JS thread, but I believe it should be addressed in some other PR 👍

@mfrachet
Copy link
Owner Author

Yep, just having an issue with test that are not running anymore for some reasons here :)

@FadiAboMsalam
Copy link

@mfrachet do you have any idea when this will be merged 🤔 ?

@mfrachet
Copy link
Owner Author

mfrachet commented Jun 7, 2020

@FadiAboMsalam when I'll figure out why testing doesn't work anymore :(

@tranvanquang
Copy link

How can I fix It? I think u should using useNativeDriver same useNativeDriver in animation?

@mfrachet
Copy link
Owner Author

mfrachet commented Jun 9, 2020

Closing in favor of #124

@mfrachet mfrachet closed this Jun 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Animated: "useNativeDriver" was not specified warning
4 participants