-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing useNativeDriver warning #121
Conversation
Is is possible to set useNativeDriver to true? Without useNativeDriver, all the work is done on the JS thread, causing frame drops in our applications. I know there are limitations when to use useNativeDriver, but maybe we could improve this somehow 🤷♂️ Thanks for your work 🚀 |
I can't do this on every single animations since useNativeDriver works only for transition and opacity things :/ There's already an issue to move the animation on the main thread instead #99 but I honestly don't have time to rework this for now :/ |
No worries, maybe someone with enough experience can take a look 🚀 Thanks for fixing! |
@mfrachet I think we can merge to get rid of this warning. Maybe in the future someone can have an idea to avoid block the JS thread, but I believe it should be addressed in some other PR 👍 |
Yep, just having an issue with test that are not running anymore for some reasons here :) |
@mfrachet do you have any idea when this will be merged 🤔 ? |
@FadiAboMsalam when I'll figure out why testing doesn't work anymore :( |
How can I fix It? I think u should using useNativeDriver same useNativeDriver in animation? |
Closing in favor of #124 |
Should fix #120