Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bands #12

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Bands #12

wants to merge 6 commits into from

Conversation

WuyihanVictor
Copy link
Contributor

  • Support compute_bands for an explicit kpath, and save results to compute_bands.json
  • Check for SCF convergence before running POSTSCF. If SCF is not converged, POSTSCF will not run
  • Support SCF maxtime. If not specified, maxtime = Year(1)

@mfherbst
Copy link
Owner

mfherbst commented Aug 4, 2024

Thanks, I cleaned up the maxtime code a bit in #14. For the kpoints / bands I have no idea how to do that properly as I know too little about the python side.

I think the basic idea you propose is reasonable, but it might also be nice to be able to just run the computation without explicitly specifying the path. What I'm thinking is to just run supply a kline_density and let DFTK figure out the kpath by itself, for example. But in line with the above, not sure to what extend this makes sense.

My intuition is to work with an interpolation syntax like $ExplicitKpoints again, just to reserve the right to generalise to other things later.

@WuyihanVictor
Copy link
Contributor Author

Thanks, I cleaned up the maxtime code a bit in #14. For the kpoints / bands I have no idea how to do that properly as I know too little about the python side.

I think the basic idea you propose is reasonable, but it might also be nice to be able to just run the computation without explicitly specifying the path. What I'm thinking is to just run supply a kline_density and let DFTK figure out the kpath by itself, for example. But in line with the above, not sure to what extend this makes sense.

My intuition is to work with an interpolation syntax like $ExplicitKpoints again, just to reserve the right to generalise to other things later.

Sorry for late reply.

We do have automatic generation of the k-path based on a specified k-point distance on the Python side using the Seekpath tool. Here’s an example of how it can be used: WorkChain_Si_kpoints_distance.

Additionally, AiiDA has a built-in KpointsData type, which helps maintain provenance consistency. We should also prefer to keep the data processing to a minimum on the Julia side. In this way, the julia side just needs to take an explicit k-path.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants