Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTTP exporter can listen on unix domain socket (UDS) as well as TCP #498

Merged
merged 4 commits into from
Jul 11, 2024

Conversation

scottopell
Copy link
Contributor

@scottopell scottopell commented Jul 8, 2024

HTTP over Unix Domain Sockets is useful in situations where the thing exposing telemetry does not have networking configured, but does have easy shared disk.

In my use case, this occurs because we run a container without external networking, but still want to collect telemetry from the container. This is trivial with a Unix Domain Socket mounted in a volume share.

@scottopell scottopell changed the title Adds Proof Of Concept HTTP unix domain socket listener Adds Proof Of Concept HTTP unix domain socket (UDS) listener Jul 8, 2024
@scottopell scottopell changed the title Adds Proof Of Concept HTTP unix domain socket (UDS) listener HTTP exporter can listen on unix domain socket (UDS) as well as TCP Jul 9, 2024
@scottopell scottopell marked this pull request as ready for review July 9, 2024 20:58
@tobz tobz merged commit a65dde9 into metrics-rs:main Jul 11, 2024
12 checks passed
@tobz tobz added C-exporter Component: exporters such as Prometheus, TCP, etc. E-intermediate Effort: intermediate. T-enhancement Type: enhancement. S-awaiting-release Status: awaiting a release to be considered fixed/implemented. labels Jul 11, 2024
@tobz
Copy link
Member

tobz commented Jul 11, 2024

Thanks for your contribution!

@tobz
Copy link
Member

tobz commented Jul 13, 2024

Released as [email protected].

@tobz tobz removed the S-awaiting-release Status: awaiting a release to be considered fixed/implemented. label Jul 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-exporter Component: exporters such as Prometheus, TCP, etc. E-intermediate Effort: intermediate. T-enhancement Type: enhancement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants