Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent default spec names overwriting the :name provided in st/spec #188

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

iku000888
Copy link

@iku000888 iku000888 commented Jun 1, 2019

When generating json-schema by giving it a keyword naming the spec, that is always used for the :title of the generated json-schema, ignoring the :name provided if the spec was defined using st/spec.

I modified the logic to check if there is a user provided :name and use that if available.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.005%) to 97.754% when pulling 1f6de3c on iku000888:respect-defined-name into 9fc6eea on metosin:master.

@ikitommi
Copy link
Member

ikitommi commented Jun 3, 2019

Thanks! About the impl, I believe if you just bound the name to (-> spec st/get-spec st/spec-name) is might work.

@iku000888
Copy link
Author

Hey @ikitommi thanks for looking.

Thanks! About the impl, I believe if you just bound the name to (-> spec st/get-spec st/spec-name) is might work.

Just want to update that I tried it and tests failed, and had no time to take a closer look yet.

@akshaykarle
Copy link

Hi, just ran into the same issue with the title generated in json-schema. @iku000888 @ikitommi are you still looking into this? If not I can try to fix it in my free time

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants