-
Notifications
You must be signed in to change notification settings - Fork 34
Support new date widget types #2337
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Error: widgetType Date does not allow changes
How to reproduce: Open http://localhost:3000/window/143/NEW
Try to change the Date (Dateordered). The selection of the date is not shown in Date widget. The Date is not shown in Window. The Date value in response has the changed date.
Warning backend.js: Invalid prop queryLimitHit
of type boolean
supplied to TablePagination
, expected number
.
How to reproduce: Opened window http://localhost:3000/window/143, see console
Error: Date promised initially set wrong
This seems to be backend error. Opened an issue metasfresh/metasfresh#5458 for that.
Both issues fixed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Error: After last change, the DateOrdered is now shown a day earlier (not today). Also when clicking in Opened Date widget it always selects a day earlier (weirdo :D )
Error: When creating a NEW Sales Order, the Date of Provisioning is initially empty. The WIdget is showing Invalid Date
in such a case.
Error: Time Widgets showing Invalid Date
How to reproduce: Open Window http://localhost:3000/window/540333/1000000. Check Preparation Time. (Here the Date widget issue in Field Valid from
)
Warning: Can't perform a React state update on an unmounted component.
How to reproduce: Opened Sales order Main view from Grid view. http://localhost:3000/window/143/
So I can't really reproduce this error with widget showing day earlier. I've tried switching system timezones, but still works ok. Fixed the other bug, simplified the whole thing a bit (as well as some super old TODO's) along the way. The last error is a bit tricky, and would require more digging. It doesn't really affect anything and is probably a combination of various things at the same time (the error React is showing in the console is misleading). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed the other bug, simplified the whole thing a bit (as well as some super old TODO's) along the way.
Confirmed, thanks. Works.
So I can't really reproduce this error with widget showing day earlier. I've tried switching system timezones, but still works ok.
Confirmed, not reproducible atm.
The last error is a bit tricky, and would require more digging. It doesn't really affect anything and is probably a combination of various things at the same time (the error React is showing in the console is misleading).
A similar error can be reproduced here repeatedly. In this case, has the effect that app window is emptied.
How to reproduce: Open http://localhost:3000/window/500221/1007099
Click in Field "Alt Date ready" (Date widget opens). Then click outside the Date widget (Whole application window is emptied an error message is shown in the console. Only a refresh brings the user back to the application.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR. Works as required. Found an issue in API. @teosarca will fix and integrate this PR tomorrow together with backend stuff for the DateTime changes.
API issue remaining. metasfresh/metasfresh-webui-api-legacy#1249 |
Related to #2317