Add possibility to turn off 'Area Search' filter

[pvpurcarcosmin]

refs: #1363

[metas-ts]

Pls insert de.metas.ui.web.document.geo_location.filter_disabled into AD_SysConfig.

• Why: otherwise we will generally forget that this switch actually exists
• note that then in private customization-sqls you need to update it.

"but how do i make sure the insert was already done when me little update is run - besides letting the file name start with a bigger seqno" you ask?
for that we have db_fail_unless_row_count_greater_zero, so you can do

select db_fail_unless_row_count_greater_zero('UPDATE AD_SysConfig SET Value=''N/Y/etc'', Description=''Custom setting for... See issue (private user-issue).'' WHERE AD_SysConfig_ID=...');

---

consider (coming to my mind only now) to go with ..._enabled instead of "disabled.

• why: one less ! needed in the code and in my head
• (but sticking with idsabled is also ok for me)

[pvpurcarcosmin]

Pls insert de.metas.ui.web.document.geo_location.filter_disabled into AD_SysConfig.

• Why: otherwise we will generally forget that this switch actually exists
• note that then in private customization-sqls you need to update it.

"but how do i make sure the insert was already done when me little update is run - besides letting the file name start with a bigger seqno" you ask?
for that we have db_fail_unless_row_count_greater_zero, so you can do

select db_fail_unless_row_count_greater_zero('UPDATE AD_SysConfig SET Value=''N/Y/etc'', Description=''Custom setting for... See issue (private user-issue).'' WHERE AD_SysConfig_ID=...');

consider (coming to my mind only now) to go with ..._enabled instead of "disabled.

• why: one less ! needed in the code and in my head
• (but sticking with idsabled is also ok for me)

--> agreed , the 'disabled' flag would've made sens in case we weren't going to add the sys config by default for everyone, but as we do, enabled makes more sens

[metas-ts]

Here is an overview of what got changed by this pull request:

Complexity decreasing per file
==============================
+ src/main/java/de/metas/ui/web/document/filter/provider/DocumentFilterDescriptorsProvidersService.java  -2
         

See the complete overview on Codacy