Configure DNS servers in machine allocation optionally #570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
majst01
reviewed
Sep 11, 2024
majst01
reviewed
Sep 11, 2024
| @@ -1237,6 +1239,7 @@ func allocateMachine(ctx context.Context, logger *slog.Logger, ds *datastore.Ret | |||
| VPN: allocationSpec.VPN, | |||
| FirewallRules: firewallRules, | |||
| UUID: uuid.New().String(), | |||
| DNSServers: allocationSpec.DNSServers, | |||
There was a problem hiding this comment.
some sort of validation is required like:
walk through all elements
if the element is a ip, validate with netip.ParseAddr()
else it must be a rfc conformant hostname
There was a problem hiding this comment.
This ensures a breaking OS installation
|
I would also add NTPServers in this PR as well |
|
Will be handled in a PR with dns and ntp combined. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.