Make additional announcable cidrs configurable per tenant super network #562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
majst01
force-pushed
the
additional-announcable-cidrs
branch
3 times, most recently
from
e19b33a
to
2852309
Compare
vknabel
reviewed
Aug 14, 2024
majst01
force-pushed
the
additional-announcable-cidrs
branch
from
2852309
to
85167ec
Compare
vknabel
approved these changes
Aug 14, 2024
majst01
force-pushed
the
additional-announcable-cidrs
branch
3 times, most recently
from
4df733c
to
4b6ce16
Compare
majst01
force-pushed
the
additional-announcable-cidrs
branch
from
4b6ce16
to
6430ea1
Compare
Gerrit91
reviewed
Aug 20, 2024
mwennrich
approved these changes
Aug 20, 2024
…o additional-announcable-cidrs
Gerrit91
reviewed
Aug 26, 2024
Gerrit91
reviewed
Aug 26, 2024
Gerrit91
reviewed
Aug 26, 2024
Gerrit91
approved these changes
Aug 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Actually we have the Pod- and Service- Cidrs hard coded in metal-core and add them to the route maps per machine switch port during the creation of the frr.conf on a switch.
With this we put this as a optional configuration into the super tenant network called
additionalannouncablecidrswhich can contain a slice of cidrs which should be added to the route map of every machine created in his tenant network.In metal-stack/metal-core#127 we already filter out duplicate entries in the route maps to keep backwards compatibility.
currently running in Test
TODO: