Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce firewall egress and ingress rules for firewall allocation. #491

Merged
merged 28 commits into from
Feb 15, 2024
Merged

Introduce firewall egress and ingress rules for firewall allocation. #491

merged 28 commits into from
Feb 15, 2024

Conversation

Gerrit91
Copy link
Contributor

@Gerrit91 Gerrit91 commented Jan 22, 2024 •
edited
Loading

majst01
majst01 requested changes Jan 22, 2024
View reviewed changes
cmd/metal-api/internal/metal/machine.go Outdated Show resolved Hide resolved
cmd/metal-api/internal/metal/machine.go Outdated Show resolved Hide resolved
cmd/metal-api/internal/metal/machine.go Outdated Show resolved Hide resolved
cmd/metal-api/internal/metal/machine.go Outdated Show resolved Hide resolved
cmd/metal-api/internal/service/v1/firewall.go Outdated Show resolved Hide resolved
cmd/metal-api/internal/service/v1/firewall.go Outdated Show resolved Hide resolved
@majst01 majst01 marked this pull request as ready for review February 8, 2024 12:45
@majst01 majst01 requested a review from a team as a code owner February 8, 2024 12:45
Gerrit91
Gerrit91 commented Feb 14, 2024
View reviewed changes
Copy link
Contributor Author

@Gerrit91 Gerrit91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Only minor things. I cannot approve because I opened the PR. 😅

cmd/metal-api/internal/metal/machine.go Show resolved Hide resolved
cmd/metal-api/internal/metal/machine_test.go Outdated Show resolved Hide resolved
@Gerrit91 Gerrit91 merged commit d077dc4 into master Feb 15, 2024
2 checks passed
@Gerrit91 Gerrit91 deleted the firewall-rules branch February 15, 2024 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@majst01 majst01 majst01 approved these changes

@mwennrich mwennrich mwennrich approved these changes

@ulrichSchreiner ulrichSchreiner Awaiting requested review from ulrichSchreiner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Gerrit91 @majst01 @mwennrich