Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for localfs provider #34

Merged
merged 11 commits into from
Feb 19, 2024
Merged

add support for localfs provider #34

merged 11 commits into from
Feb 19, 2024

Conversation

mschuller
Copy link
Contributor

@mschuller mschuller commented Nov 18, 2020

Closes #75.

@Gerrit91
Copy link
Contributor

Gerrit91 commented Feb 9, 2024

I think it would be nice to have a configuration parameter which specifies file names to be present in the data directory, which indicate if a restore of the data is necessary or not.

The backup should utilize the same library for creating archives as already used at a different part of the code base. Library is called github.com/mholt/archiver/v3.

Please also add an integration test for this.

@Gerrit91
Copy link
Contributor

Gerrit91 commented Feb 9, 2024

Probably it's even enough to just copy over the files to backup because the sidecar will compress the backup directory anyway.

integration/main_test.go Outdated Show resolved Hide resolved
integration/main_test.go Outdated Show resolved Hide resolved
cmd/internal/utils/files.go Outdated Show resolved Hide resolved
integration/main_test.go Outdated Show resolved Hide resolved
@Gerrit91
Copy link
Contributor

This new option should also be added to the README.md.

@Gerrit91 Gerrit91 marked this pull request as ready for review February 15, 2024 10:22
@Gerrit91 Gerrit91 requested a review from a team as a code owner February 15, 2024 10:22
Copy link
Contributor

@Gerrit91 Gerrit91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good!

README.md Outdated Show resolved Hide resolved
@Gerrit91 Gerrit91 merged commit cb567c2 into master Feb 19, 2024
2 checks passed
@Gerrit91 Gerrit91 deleted the localfs-provider branch February 19, 2024 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LocalFS Provider
4 participants