refinements

metal-stack · Aug 25, 2023 · 99daca5 · 99daca5
1 parent 6e0e9aa
commit 99daca5
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 3 deletions.
diff --git a/cmd/internal/database/meilisearch/meilisearch.go b/cmd/internal/database/meilisearch/meilisearch.go
@@ -206,6 +206,10 @@ func (db *Meilisearch) Upgrade() error {
 		if err != nil {
 			return err
 		}
+		healthy := db.client.IsHealthy()
+		if !healthy {
+			return fmt.Errorf("meilisearch does not report healthiness")
+		}
 		db.log.Infow("meilisearch started after upgrade, killing it", "version", v)
 		return cmd.Process.Signal(syscall.SIGTERM)
 	}, retry.Attempts(100))
@@ -214,7 +218,8 @@ func (db *Meilisearch) Upgrade() error {
 	}
 	err = g.Wait()
 	if err != nil {
-		return fmt.Errorf("database upgrade failed with %w", err)
+		// sending a TERM signal will always result in a error response.
+		db.log.Infow("upgrade database terminated but reported an error which can be ignored", "error", err)
 	}
 
 	db.log.Infow("upgrade done and new data in place", "took", time.Since(start))

diff --git a/deploy/meilisearch.yaml b/deploy/meilisearch.yaml
@@ -22,7 +22,7 @@ spec:
             name: auditing-meili-meilisearch-environment
         - secretRef:
             name: metal-auditing-master-key
-        image: getmeili/meilisearch:v1.2.0
+        image: getmeili/meilisearch:v1.3.1
         imagePullPolicy: IfNotPresent
         name: meilisearch
         command:
@@ -89,7 +89,7 @@ spec:
         - name: bin-provision
           subPath: tini
           mountPath: /usr/local/bin/tini
-      - image: getmeili/meilisearch:v1.2.0
+      - image: getmeili/meilisearch:v1.3.1
         name: backup-restore-sidecar
         command:
         - tini