Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LB-1628: LB radio 429 fix #151

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

LB-1628: LB radio 429 fix #151

wants to merge 2 commits into from

Conversation

mayhem
Copy link
Member

@mayhem mayhem commented Sep 5, 2024

LB-1628 points out that LB Radio is crap at dealing with rate limiting, so this PR ensures that request calls handle 439/503 correctly.

Also, for some queries more than 1,000 items were generated, which caused problems. Truncating to first 1,000 tracks is a sufficient fix for this.

Add rate limit support to all modules making web requests.
Copy link

github-actions bot commented Sep 5, 2024

Test Results

  4 files  ±0    4 suites  ±0   4s ⏱️ ±0s
 50 tests ±0   50 ✅ ±0  0 💤 ±0  0 ❌ ±0 
200 runs  ±0  200 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit d931c4d. ± Comparison against base commit 2f3a152.

Copy link

github-actions bot commented Sep 5, 2024

Package Line Rate Complexity Health
. 32% 0
content_resolver 0% 0
content_resolver.formats 6% 0
content_resolver.model 0% 0
external 39% 0
listenbrainz 46% 0
musicbrainz 71% 0
patches 27% 0
patches.lb_radio_classes 0% 0
tools 20% 0
. 32% 0
content_resolver 0% 0
content_resolver.formats 6% 0
content_resolver.model 0% 0
external 39% 0
listenbrainz 46% 0
musicbrainz 71% 0
patches 27% 0
patches.lb_radio_classes 0% 0
tools 20% 0
. 32% 0
content_resolver 0% 0
content_resolver.formats 6% 0
content_resolver.model 0% 0
external 39% 0
listenbrainz 45% 0
musicbrainz 69% 0
patches 27% 0
patches.lb_radio_classes 0% 0
tools 20% 0
. 32% 0
content_resolver 0% 0
content_resolver.formats 6% 0
content_resolver.model 0% 0
external 39% 0
listenbrainz 46% 0
musicbrainz 71% 0
patches 27% 0
patches.lb_radio_classes 0% 0
tools 20% 0
Summary 21% (4174 / 19975) 0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant