Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SoundCloud import tracks fix #150

Merged
merged 13 commits into from
Sep 2, 2024

Conversation

rimma-kubanova
Copy link
Contributor

Thanks to @anshg1214 for highlighting this in the PR. We noticed that importing playlists from SoundCloud wasn't functioning correctly

The issue stemmed from the endpoint output. After updating the API callback to support pagination, it returned tracks but omitted playlist details.

I discovered that the playlist endpoint doesn’t support pagination, so I implemented a separate endpoint specifically for fetching the playlist name and description.

This approach seems effective, and I’m considering applying a similar solution for other services

@amCap1712 amCap1712 merged commit 2f3a152 into metabrainz:main Sep 2, 2024
4 checks passed
Copy link
Member

@amCap1712 amCap1712 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants