Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration fixes #135

Merged
merged 35 commits into from
Apr 26, 2024
Merged

Integration fixes #135

merged 35 commits into from
Apr 26, 2024

Conversation

mayhem
Copy link
Member

@mayhem mayhem commented Apr 25, 2024

After the refactoring of LB Radio and the implementation of the new LB Radio backends, a lot of cleanup and integration was still necessary. In this PR I:

  • Finish debugging the new parser with better error messages
  • Improve error message handling overall.
  • Add support for the country element.
  • Integrate new artist and tag search back-ends
  • Get rid of old splitter class.
  • Update docs to reflect new syntax.

Copy link

github-actions bot commented Apr 25, 2024

Test Results

  4 files  ±0    4 suites  ±0   4s ⏱️ ±0s
 50 tests  - 1   50 ✅  - 1  0 💤 ±0  0 ❌ ±0 
200 runs   - 4  200 ✅  - 4  0 💤 ±0  0 ❌ ±0 

Results for commit 5b27377. ± Comparison against base commit 29dd4b2.

This pull request removes 4 and adds 3 tests. Note that renamed tests count towards both.
tests.test_splitter.TestSplitter ‑ test_plist
tests.test_splitter.TestSplitter ‑ test_splitter_basic
tests.test_splitter.TestSplitter ‑ test_splitter_mod_operation
tests.test_splitter.TestSplitter ‑ test_splitter_short
tests.test_parser.TestParser ‑ test_country
tests.test_plist.TestSplitter ‑ test_plist
tests.test_plist.TestSplitter ‑ test_plist_unique

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Apr 25, 2024

Package Line Rate Complexity Health
. 33% 0
content_resolver 0% 0
content_resolver.formats 6% 0
content_resolver.model 0% 0
external 39% 0
listenbrainz 46% 0
musicbrainz 71% 0
patches 25% 0
patches.lb_radio_classes 0% 0
tools 74% 0
. 33% 0
content_resolver 0% 0
content_resolver.formats 6% 0
content_resolver.model 0% 0
external 39% 0
listenbrainz 46% 0
musicbrainz 71% 0
patches 25% 0
patches.lb_radio_classes 0% 0
tools 74% 0
. 33% 0
content_resolver 0% 0
content_resolver.formats 6% 0
content_resolver.model 0% 0
external 39% 0
listenbrainz 45% 0
musicbrainz 71% 0
patches 25% 0
patches.lb_radio_classes 0% 0
tools 74% 0
. 33% 0
content_resolver 0% 0
content_resolver.formats 6% 0
content_resolver.model 0% 0
external 39% 0
listenbrainz 46% 0
musicbrainz 71% 0
patches 25% 0
patches.lb_radio_classes 0% 0
tools 74% 0
Summary 22% (4024 / 18000) 0

Copy link
Member

@amCap1712 amCap1712 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks!

@mayhem mayhem merged commit ced8785 into main Apr 26, 2024
6 checks passed
@mayhem mayhem deleted the integration-fixes branch April 26, 2024 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants