Prefill donation form if user is logged in #483
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mayhem
approved these changes
Sep 11, 2024
MonkeyDo
reviewed
Sep 12, 2024
There was a problem hiding this comment.
@mayhem also mentioned that we might want to allow pre-filling the donation amount as well, I reckon with a url parameter (what about currency?).
I'm not sure if that was specifically and only for the LB donations page, but it seems like a logical thing to have available.
|
@MonkeyDo Added prefill for donation and currency. Also, added prefill for editor name from url with a fallback to current logged in user's name if editor is not supplied in the url. |
MonkeyDo
added a commit
to metabrainz/listenbrainz-server
that referenced
this pull request
Oct 14, 2024
The ?amount=... param was added to the MeB.org donation page in metabrainz/metabrainz.org#483
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.