Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MEB-143: Update projects page v2 #452

Merged
merged 4 commits into from
Dec 4, 2023

Conversation

Aerozol
Copy link
Contributor

@Aerozol Aerozol commented Nov 30, 2023

Remove AcousticBrainz and MessyBrainz from:
https://metabrainz.org/projects

This pull moves them to a 'Past Projects' section instead of removing them, as suggested by yvanzo in: #449

Remove AcousticBrainz and MessyBrainz from:
https://metabrainz.org/projects

This commit moves them to a 'Past Projects' section instead of removing them, as suggested by yvanzo in: metabrainz#449
There can be only one element with the same id in a page.
Hopefully the id wasn’t used for anything else than applying style.
To have two elements that follow the same style, we use a class instead.
There can be only one page title. List past projects in a subsection.
Copy link
Contributor

@yvanzo yvanzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new text looks good using past tense. I pushed commits fixing page layout using only one h1 element, attributes for proper CSS style application, and code indent. I tested it locally and took the following screenshot for you to review:
metabrainz org-projects-9232e9b

Copy link
Member

@mayhem mayhem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@yvanzo yvanzo merged commit a84b082 into metabrainz:master Dec 4, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants