Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable_global no longer exists #439

Merged
merged 1 commit into from
Oct 20, 2023
Merged

enable_global no longer exists #439

merged 1 commit into from
Oct 20, 2023

Conversation

mayhem
Copy link
Member

@mayhem mayhem commented Oct 10, 2023

Not sure why this died now, but sending invoices no longer worked. Removing it and everything works. Odd.

@github-actions
Copy link

Unit Test Results

  1 files  ±0    1 suites  ±0   11s ⏱️ ±0s
67 tests ±0  67 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 5b62387. ± Comparison against base commit 12f5c6d.

@mayhem mayhem requested a review from amCap1712 October 10, 2023 10:38
Copy link
Contributor

@MonkeyDo MonkeyDo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

enable_global was deprecated in 2021 and removed in March of 2023:
https://github.com/ej2/python-quickbooks/releases/tag/0.9.3

https://github.com/ej2/python-quickbooks/blob/master/CHANGELOG.rst

I know nothing of QuickBooks, but it looks sane to remove it.

@mayhem mayhem merged commit 9064a7c into master Oct 20, 2023
2 checks passed
@mayhem mayhem deleted the quickbooks-fix branch October 20, 2023 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants