Subscriptions using Stripe #375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
|
Bump! |
This comment has been minimized.
This comment has been minimized.
|
We decided on IRC some months ago that manual cancellation for now is fine. |
amCap1712
force-pushed
the
subscription
branch
from
c896f21
to
523ca9b
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Unit Test Results 1 files ±0 1 suites ±0 17s ⏱️ ±0s For more details on these failures, see this check. Results for commit d11531e. ± Comparison against base commit d11531e. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation is able to create subscriptions but not cancel them. Cancelling stripe subscriptions requires us to store the donor's stripe customer id. This means that we'll need auth for stripe recurring subscriptions. Otherwise, we cannot be sure that a user's subscription is not messed up with by someone else. Before we go ahead to implement this, we should consider if this added complexoty is worth it.