Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rethink album grouping on artist page #2998

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

MonkeyDo
Copy link
Contributor

User rustynova had the excellent suggestion regarding the album sorting, following improvements in #2985 :

Or maybe also add subtypes lists, but for all the types. I don't see any reason to separate single remixes and album remixes

On a technical level, what this means is that instead of grouping like on the MusicBrainz website each primary type followed by each secondary type, we are grouping first by secondary type and then by primary type.
We only use the first secondary type even if there are multiple, for extra simplifying.

This means we end up with secondary type categories like "live", "compilation", "demo" etc. regardless of the primary types they contain (so "album + remix", "single + remix" and "other + remix" all end up in the same "remix" category).

This results in a page with fewer categories, but ones that make sense from a user point of view.

Compare for example The Beatles' page:
image

This PR:
image

MonkeyDo and others added 3 commits October 11, 2024 20:00
Sort by the more precise secondary type first to create categories like "Live", "Compilation" and "Remix" instead of "Album + Live", "Single + Live", "EP + Live", "Broadcast + Live" and "Album + Remix", etc.
EP before Single was suggested in the LB channel, as well as not having "Other" before other types.
@reosarevok
Copy link
Member

reosarevok commented Oct 14, 2024

Is it intentional to disregard every secondary type except one? If something is both a compilation and live, shouldn't it appear on both sections if you're splitting like this?

@MonkeyDo
Copy link
Contributor Author

Is it intentional to disregard every secondary type except one? If something is both a compilation and live, shouldn't it appear on both sections if you're splitting like this?

I guess I went for the simplest solution, although I'll concede it's probably not ideal.
Do you think it would be better to duplicate the item and show it in both categories? I thought that would be confusing and went for the simpler method (code-wise) that would also limit the complexity of the page.

It doesn't make the selection of the category wrong per se (i.e. if compilation+live and it ends up in complication only or in live only, the selection will still be "correct" although arguably incomplete), but maybe duplication would be better?
From my understanding you would probably have to be coming from the MB page to realize something is different, but maybe there will be cases that are confusing from the get-go?

I can definitely be possible to duplicate the items in multiple categories, but not with the current lodash utility as far as I know.

@reosarevok
Copy link
Member

My only worry is whether users will be confused that they're looking for all live releases and miss some because they're also under something else, for example. But admittedly, the default MB presentation is not significantly better for that issue - so it might be fine like this. Something for you and @Aerozol to decide, I was just bringing up the issue to make sure it was a decision and not just a mistake.

@MonkeyDo
Copy link
Contributor Author

My only worry is whether users will be confused that they're looking for all live releases and miss some because they're also under something else, for example. But admittedly, the default MB presentation is not significantly better for that issue - so it might be fine like this. Something for you and @Aerozol to decide, I was just bringing up the issue to make sure it was a decision and not just a mistake.

It was a decision, but motivated by lazyness rather than a deep calculation, so I think the point stands, thank you :)

We could end up prioritizing certain secondary types over others depending on how relevant we think they are for users.
Example code shared by reo from MB webservice backwards compatibility:
https://github.com/metabrainz/musicbrainz-server/blob/de898cc4e8fede8c459c8eee67e626a72c3a6326/lib/MusicBrainz/Server/WebService/XMLSerializer.pm#L281-L288

@Aerozol
Copy link
Contributor

Aerozol commented Oct 15, 2024

I haven't looked super closely, but I think we can use these early days of LB to try out changes like this without worrying too much - as long as you are okay to stay flexible and change it back if there is some disaster that we haven't foreseen, monkey!

P.S. I couldn't find where the 'Album + Demo' release "Anthology Sessions" goes in the new layout? Either I've missed it or it's gotten itself disappeared.

P.P.S It might also free up that space on the album card where we display stuff like "Album", which is redundant if the sections is already called Album (or maybe the repetition is good?)

I will also paste in what I said to monkey on Matrix, cut for relevance:
I think that page is getting too long/tall for LB’s target audience tbh. Us data nerds want to see every single, sure, but I think the pleb listener (said with love/lols) wants an overview and then to see what else we offer - reviews, similar artist map, similar artists, etc.
I think it could be a bit weird to mix remix albums and remix singles for some artists, but honestly, anything that shortens the page is a +1 from me!

@reosarevok
Copy link
Member

reosarevok commented Oct 15, 2024

It might also free up that space on the album card where we display stuff like "Album"

If anything that seems more important now that the Live section displays different things and you need a way to tell if it's Single, EP or Album, doesn't it?

I think that page is getting too long/tall for LB’s target audience tbh

Any reason not to just show the discography collapsed at first, showing just a couple rows of albums with a "see all" link that shows the whole thing? I guess it would need a "Discography" heading or something like that then, but tbh I'd want that even now, since otherwise I feel it's a big untitled section with many rows in between other, unrelated things.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants