fix env vars

metabrainz · May 7, 2024 · 43cca40 · 43cca40
1 parent 57e2a8d
commit 43cca40
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 4 deletions.
diff --git a/.github/workflows/package-macos.yml b/.github/workflows/package-macos.yml
@@ -45,10 +45,11 @@ jobs:
         env:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
           APPLE_ID: ${{ secrets.APPLE_ID_USER }}
-          APPLE_ID_TEAM: ${{ secrets.APPLE_ID_TEAM }}
-          APPLE_ID_PASS: ${{ secrets.APPLE_ID_PASSWORD }}
+          APPLE_TEAM_ID: ${{ secrets.APPLE_ID_TEAM }}
+          APPLE_APP_SPECIFIC_PASSWORD: ${{ secrets.APPLE_ID_PASSWORD }}
           CSC_LINK: ./appledev.p12
           CSC_KEY_PASSWORD: ${{ secrets.CODESIGN_MACOS_P12_PASSWORD }}
 
       - name: Cleanup
         run: rm -f ./appledev.p12
+        if: always()
diff --git a/notarize.js b/notarize.js
@@ -25,7 +25,7 @@ exports.default = async function notarizeMacos(context) {
     appBundleId: build.appId,
     appPath: `${appOutDir}/${appName}.app`,
     appleId: process.env.APPLE_ID,
-    appleIdPassword: process.env.APPLE_ID_PASS,
-    ascProvider: process.env.APPLE_ID_TEAM,
+    appleIdPassword: process.env.APPLE_APP_SPECIFIC_PASSWORD,
+    teamId: process.env.APPLE_TEAM_ID,
   });
 };
diff --git a/package.json b/package.json
@@ -53,6 +53,7 @@
           "x64"
         ]
       },
+      "icon": "./assets/icon.icns",
       "type": "distribution",
       "hardenedRuntime": true,
       "entitlements": "./assets/entitlements.mac.plist",