Merge branch 'bad-urls'

metabrainz · Apr 11, 2022 · c55d502 · c55d502
2 parents fdbb470 + 94eee08
commit c55d502
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/critiquebrainz/frontend/templates/review/entity/work.html b/critiquebrainz/frontend/templates/review/entity/work.html
@@ -17,7 +17,7 @@ <h2 id="title">
 
     {{ _('%(work)s', work=work_name) }}
 
-    {% if work['life-span'] %}
+    {% if work['life-span'] is defined %}
       <small>{{ work['life-span']['begin'][:4] }}</small>
     {% endif %}
   </h2>

diff --git a/critiquebrainz/frontend/views/artist.py b/critiquebrainz/frontend/views/artist.py
@@ -65,7 +65,7 @@ def entity(id):
         raise BadRequest("Invalid page number!")
 
     if page < 1:
-        return redirect(url_for('.reviews'))
+        return redirect(url_for('artist.entity', id=id))
     release_groups_offset = (page - 1) * BROWSE_RELEASE_GROUPS_LIMIT
     release_groups, release_group_count = mb_release_group.browse_release_groups(
         artist_id=artist['mbid'],

diff --git a/critiquebrainz/frontend/views/work.py b/critiquebrainz/frontend/views/work.py
@@ -47,7 +47,7 @@ def entity(id):
         raise BadRequest("Invalid page number!")
 
     if page < 1:
-        return redirect(url_for('.reviews'))
+        return redirect(url_for('work.entity', id=id))
 
     recording_rels = work['recording-rels']
     recording_count = len(recording_rels)