Skip to content

Commit

Permalink
Set isolation level manually when we don't want an explicit transaction
Browse files Browse the repository at this point in the history
Can't create extensions in a transaction
  • Loading branch information
alastair committed Oct 25, 2022
1 parent c671602 commit 9c3e58d
Showing 1 changed file with 1 addition and 3 deletions.
4 changes: 1 addition & 3 deletions critiquebrainz/db/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -28,8 +28,7 @@ def run_sql_script(sql_file_path):


def run_sql_script_without_transaction(sql_file_path):
with open(sql_file_path) as sql, engine.begin() as connection:
connection.connection.set_isolation_level(0)
with open(sql_file_path) as sql, engine.connect().execution_options(isolation_level="AUTOCOMMIT") as connection:
lines = sql.read().splitlines()
try:
for line in lines:
Expand All @@ -41,6 +40,5 @@ def run_sql_script_without_transaction(sql_file_path):
print("Error: {}".format(e))
return False
finally:
connection.connection.set_isolation_level(1)
connection.close()
return True

0 comments on commit 9c3e58d

Please sign in to comment.