Merge pull request #501 from metabrainz/replace-simplemde

Replace SimpleMDE library with EasyMDE
metabrainz · Oct 31, 2023 · 1ff9d6e · 1ff9d6e
2 parents 16dc198 + 48beef7
commit 1ff9d6e
Show file tree

Hide file tree

Showing 7 changed files with 2,952 additions and 2,898 deletions.
diff --git a/critiquebrainz/frontend/static/scripts/wysiwyg-editor.js b/critiquebrainz/frontend/static/scripts/wysiwyg-editor.js
@@ -1,2 +1,3 @@
-var SimpleMDE = require('simplemde');
-window.SimpleMDE = SimpleMDE;
+import '../../../../node_modules/easymde/dist/easymde.min.css';
+var EasyMDE = require('easymde');
+window.EasyMDE = EasyMDE;
diff --git a/critiquebrainz/frontend/templates/common.html b/critiquebrainz/frontend/templates/common.html
@@ -1,5 +1,5 @@
 {% set rating_script %}
-<link rel="stylesheet" href="https://cdn.jsdelivr.net/simplemde/latest/simplemde.min.css"/>
+<link rel="stylesheet" href="{{ get_static_path('wysiwyg-editor.css') }}"/>
 <script>
     $(document).ready(function () {
         $("#ratestars").click(function (e) {

diff --git a/critiquebrainz/frontend/templates/review/entity/comments.html b/critiquebrainz/frontend/templates/review/entity/comments.html
@@ -13,7 +13,7 @@
             </a>
             <button class="comment-edit-button btn btn-primary btn-xs"
                     title="{{ _('Edit this comment') }}">
-              <span class="glyphicon glyphicon-edit"></span>  
+              <span class="glyphicon glyphicon-edit"></span>
             </button>
           {% endif %}
           <span style="float:right;">
@@ -48,12 +48,12 @@
 
 
 {% block scripts %}
-  <link rel="stylesheet" href="https://cdn.jsdelivr.net/simplemde/latest/simplemde.min.css"/>
+<link rel="stylesheet" href="{{ get_static_path('wysiwyg-editor.css') }}"/>
   <script src="{{ get_static_path('wysiwyg-editor.js') }}"></script>
   <script>
     $(document).ready(function() {
       commentMdes = {};
-      commentMdes["commentAddForm"] = new SimpleMDE({
+      commentMdes["commentAddForm"] = new EasyMDE({
         element: $("#comment-add-form").find(".comment-text")[0],
         spellChecker: false
       });
@@ -92,8 +92,8 @@
         commentContentDiv.toggle();
 
         if (!commentMdes[commentDivId]) {
-          // if no simplemde object is created for this comment, create it
-          commentMdes[commentDivId] = new SimpleMDE({
+          // if no EasyMDE object is created for this comment, create it
+          commentMdes[commentDivId] = new EasyMDE({
             element: commentText,
             spellChecker: false
           });

diff --git a/critiquebrainz/frontend/templates/review/modify/base.html b/critiquebrainz/frontend/templates/review/modify/base.html
@@ -60,11 +60,11 @@
 
 {% block scripts %}
   {{ super() }}
-  <link rel="stylesheet" href="https://cdn.jsdelivr.net/simplemde/latest/simplemde.min.css"/>
+  <link rel="stylesheet" href="{{ get_static_path('wysiwyg-editor.css') }}"/>
   <script src="{{ get_static_path('wysiwyg-editor.js') }}"></script>
   <script>
     $(document).ready(function() {
-      reviewContentEditor = new SimpleMDE({
+      reviewContentEditor = new EasyMDE({
         element: $('#review-content')[0],
         spellChecker: false
       });
@@ -84,7 +84,7 @@
       oldReviewLength = reviewContentEditor.value().length
       languageSelector = $('#review-language')[0]
       // Detect the language of the review on change
-      // codemirror is the underlying editor behind SimpleMDE.
+      // codemirror is the underlying editor behind EasyMDE.
       reviewContentEditor.codemirror.on("change", function() {
         const MIN_DIFFERENCE = 10