Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[functionality] Implement completion() methods #168 #173

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[functionality] Implement completion() methods #168 #173

wants to merge 1 commit into from
+120 −93

Conversation

C0deXG
Copy link

@C0deXG C0deXG commented Oct 2, 2024

  • Implemented completion() method for meta-reference, fireworks, together, ollama, and bedrock providers
  • Each implementation handles both streaming and non-streaming responses
  • Converted single content to messages when necessary
  • Ensured proper yield of CompletionResponse or CompletionResponseStreamChunk objects

@ggroup3
[functionality] Implement completion() methods meta-llama#168
abe32f5 
   - Implemented completion() method for meta-reference, fireworks, together, ollama, and bedrock providers
   - Each implementation handles both streaming and non-streaming responses
   - Converted single content to messages when necessary
   - Ensured proper yield of CompletionResponse or CompletionResponseStreamChunk objects
@facebook-github-bot
Copy link

Hi @C0deXG!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Meta Open Source bot. label Oct 2, 2024
ashwinb
ashwinb reviewed Oct 2, 2024
View reviewed changes
llama_stack/providers/impls/meta_reference/inference/inference.py
completion_message=message,
logprobs=logprobs if request.logprobs else None,
)
buffer = buffer[len("
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

uh oh, this looks like an unintentional deletion?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

uh oh, this looks like an unintentional deletion?

in my machine is not cut off i dont know why

@ashwinb
Copy link
Contributor

ashwinb commented Oct 2, 2024

Can you also run pre-commit:

cd llama-stack
pip install pre-commit
pre-commit install

then -- whenever you run any git commit, it will run the linting hooks.

@C0deXG
Copy link
Author

C0deXG commented Oct 2, 2024

Can you also run pre-commit:

cd llama-stack
pip install pre-commit
pre-commit install

then -- whenever you run any git commit, it will run the linting hooks.

yes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashwinb ashwinb ashwinb left review comments

@yanxi0830 yanxi0830 Awaiting requested review from yanxi0830 yanxi0830 is a code owner

@hardikjshah hardikjshah Awaiting requested review from hardikjshah hardikjshah is a code owner

@dltn dltn Awaiting requested review from dltn dltn is a code owner

@raghotham raghotham Awaiting requested review from raghotham raghotham is a code owner

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Meta Open Source bot.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@C0deXG @facebook-github-bot @ashwinb @ggroup3