Skip to content

Commit

Permalink
Remove dependency of weggli
Browse files Browse the repository at this point in the history
Reviewed By: laurendeason

Differential Revision: D66972954

fbshipit-source-id: 082ece378de78e8f723bfde36eeaf43ac8566140
  • Loading branch information
SimonWan authored and facebook-github-bot committed Dec 9, 2024
1 parent 91b99f7 commit 7bbf1fc
Show file tree
Hide file tree
Showing 3 changed files with 0 additions and 46 deletions.
6 changes: 0 additions & 6 deletions .github/workflows/tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -30,11 +30,5 @@ jobs:
default: true
override: true

- name: Install Weggli
uses: actions-rs/cargo@v1
with:
command: install
args: weggli --rev=9d97d462854a9b682874b259f70cc5a97a70f2cc --git=https://github.com/weggli-rs/weggli

- name: Run Cybersecurity Benchmark Tests
run: CybersecurityBenchmarks/scripts/run_tests.sh
20 changes: 0 additions & 20 deletions CybersecurityBenchmarks/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -77,26 +77,6 @@ which contains detailed instructions on how to execute our benchmarks.

# Getting Started

## Prerequisites

Please make sure you are running python3.9 or newer versions.

Also ensure you have [weggli](https://github.com/weggli-rs/weggli) installed.
Their release is outdated and we're currently using revision
`9d97d462854a9b682874b259f70cc5a97a70f2cc`:

```
cargo install weggli --rev=9d97d462854a9b682874b259f70cc5a97a70f2cc --git=https://github.com/weggli-rs/weggli
```

Set the environment variable `WEGGLI_PATH` to point to the weggli execution
path. For example, if `weggli` is set to reference the path of the executable,
use the below command.

```
export WEGGLI_PATH=weggli
```

## Set up Virtual Environment

Set up your virtual environment and install dependencies:
Expand Down
20 changes: 0 additions & 20 deletions CybersecurityBenchmarks/website/docs/user_guide/getting_started.md
Original file line number Diff line number Diff line change
@@ -1,25 +1,5 @@
# Getting Started

## Prerequisites

Please make sure you are running python3.9 or newer versions.

Also ensure you have [weggli](https://github.com/weggli-rs/weggli) installed.
Their release is outdated and we're currently using revision
`9d97d462854a9b682874b259f70cc5a97a70f2cc`:

```
cargo install weggli --rev=9d97d462854a9b682874b259f70cc5a97a70f2cc --git=https://github.com/weggli-rs/weggli
```

Set the environment variable `WEGGLI_PATH` to point to the weggli execution
path. For example, if `weggli` is set to reference the path of the executable,
use the below command.

```
export WEGGLI_PATH=weggli
```

## Set up Virtual Environment

Set up your virtual environment and install dependencies:
Expand Down

0 comments on commit 7bbf1fc

Please sign in to comment.