Assorted tweaks to pyproject.toml
#475
Conversation
rgommers
added
the
maintenance
Remove the beta development status, add the "build tools" category.
dnicolodi
force-pushed
the
pyproject-tweaks
branch
from
235e4ec
to
e6dce78
Compare
dnicolodi
force-pushed
the
pyproject-tweaks
branch
from
e6dce78
to
d3ce933
Compare
| { name = 'Ralf Gommers ', email = '[email protected]' }, | ||
| { name = 'Daniele Nicolodi', email = '[email protected]' }, | ||
| { name = 'Henry Schreiner', email = '[email protected]' }, | ||
| { name = 'Thomas Li'}, |
There was a problem hiding this comment.
PyPI makes a mess of this. It shows Thomas as the only maintainer but links his name to Ralf's email.
Also the license appears again in a funny way, it now displays the first lines of LICENSES/MIT.txt
There was a problem hiding this comment.
Hmm, not sure what's up with the maintainers field. Possibly because email for Thomas is missing? I didn't notice that before. If that doesn't fix it, I guess we should remove this change for now.
License looks as expected to me. PyPI fixed the problem where that full license text would horribly overflow. It's much better than it was before. Of course, even better would be to finish and implement PEP 639, so we can see the SPDX classifier ....
There was a problem hiding this comment.
The PyPI page says "Maintaner" singular, thus I'm not sure PyPI has support for multiple maintainers listed in the package metadata. It is a bit annoying that the package metadata specification and the main cunsumer of it are so out of sync. I thought that the license field was fixed doing something like what Github does: match the license text and provide a short license identifier. I must have dreamed of this.
There was a problem hiding this comment.
Re maintainers: maybe we should just comment it out now and list "The meson-python maintainers"? We have a full list in the docs already.
I thought that the license field was fixed doing something like what Github does: match the license text and provide a short license identifier. I must have dreamed of this.
There's some setuptools-specific old way of doing this I believe, taking it from classifiers if the license field under [project] isn't used. Deleting a standardized PEP 621 entry to go back to something undocumented doesn't seem quite right though, so I have this one filed under "revisit when PEP 639 is done".
There was a problem hiding this comment.
Re maintainers: maybe we should just comment it out now and list "The meson-python maintainers"? We have a full list in the docs already.
Sure. I listed the names because I thought that having an entity there with an associated email address may be useful. PyPI lists you as a maintainer, I guess because your user is associated with the project. I'm fine having just you listed as a maintainer in the metadata.
There's some setuptools-specific old way of doing this I believe, taking it from classifiers if the
licensefield under[project]isn't used. Deleting a standardized PEP 621 entry to go back to something undocumented doesn't seem quite right though, so I have this one filed under "revisit when PEP 639 is done".
Yes, indeed. Let's keep things as they are for now.
There was a problem hiding this comment.
Uhm. The way PyPI reports the maintainers list may be due to how we generate the metadata. This is how the metadata fields related to the maintainers look like:
Maintainer: Thomas Li
Maintainer-Email: Ralf Gommers <[email protected]>, Daniele Nicolodi <[email protected]>, Henry Schreiner <HenrySchrein
I'm verifying what the specification prescribes, but at a first look that seems wrong.
There was a problem hiding this comment.
At least the Maintainer-Email field is wrong, as it is supposed to be an RFC-822 From header compliant format https://packaging.python.org/en/latest/specifications/core-metadata/#maintainer-email The specification does not specify how multiple maintainers should be listed
There was a problem hiding this comment.
Lovely, the specification for pyproject.toml contradicts the specification for the metadata file https://packaging.python.org/en/latest/specifications/declaring-project-metadata/#authors-maintainers
No description provided.