Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENH: add objc and objcpp to the $ARCHFLAGS generated cross file #470

Merged
merged 1 commit into from
Sep 5, 2023
Merged

ENH: add objc and objcpp to the $ARCHFLAGS generated cross file #470

merged 1 commit into from
Sep 5, 2023

Conversation

dnicolodi
Copy link
Member

Allows $ARCHFLAGS enabled cross compilation of objc and objcpp.

Fixes #468.

@dnicolodi
ENH: add objc and objcpp to the $ARCHFLAGS generated cross file
8dc8140 
Allows $ARCHFLAGS enabled cross compilation of objc and objcpp.

Fixes mesonbuild#468.
@dnicolodi dnicolodi mentioned this pull request Sep 2, 2023
Closed
@rgommers rgommers added the enhancement New feature or request label Sep 2, 2023
@rgommers rgommers added this to the v0.14.0 milestone Sep 2, 2023
rgommers
rgommers approved these changes Sep 2, 2023
View reviewed changes
Copy link
Contributor

@rgommers rgommers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM. Should be good to go as soon as @QuLogic confirms it works.

@rgommers
Copy link
Contributor

rgommers commented Sep 4, 2023

I think we can merge this and then release 0.14.0; this is almost certainly correct and if not, we can easily fix it in 0.14.1. Sound good @dnicolodi?

@dnicolodi
Copy link
Member Author

Yes, no objections from my side.

@rgommers
Copy link
Contributor

rgommers commented Sep 4, 2023

Great, I'll try to do that tomorrow morning then.

@rgommers rgommers merged commit 8842ba3 into mesonbuild:main Sep 5, 2023
23 checks passed
@rgommers
Copy link
Contributor

rgommers commented Sep 5, 2023

New release is up!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rgommers rgommers rgommers approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
v0.14.0
Development

Successfully merging this pull request may close these issues.

macOS cross file is missing Objective-C compiler
2 participants
@dnicolodi @rgommers