Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jones Technology Foundation #6070

Closed
wants to merge 2 commits into from
Closed

Conversation

ijunxyz123
Copy link

@ijunxyz123 ijunxyz123 commented Nov 21, 2024

📑 Summary

Brief description about the content of your PR.

Resolves #

📏 Design Decisions

Describe the way your implementation works or what design decisions you made if applicable.

📋 Tasks

Make sure you

  • 📖 have read the contribution guidelines
  • 💻 have added necessary unit/e2e tests.
  • 📓 have added documentation. Make sure MERMAID_RELEASE_VERSION is used for all new features.
  • 🦋 If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Copy link

changeset-bot bot commented Nov 21, 2024

⚠️ No Changeset found

Latest commit: b7f7437

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

netlify bot commented Nov 21, 2024

Deploy Preview for mermaid-js ready!

Name Link
🔨 Latest commit b7f7437
🔍 Latest deploy log https://app.netlify.com/sites/mermaid-js/deploys/673f288a38beae00089ffae7
😎 Deploy Preview https://deploy-preview-6070--mermaid-js.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

pkg-pr-new bot commented Nov 21, 2024

Open in Stackblitz

pnpm add https://pkg.pr.new/mermaid-js/mermaid@6070
pnpm add https://pkg.pr.new/mermaid-js/mermaid/@mermaid-js/mermaid-zenuml@6070
pnpm add https://pkg.pr.new/mermaid-js/mermaid/@mermaid-js/layout-elk@6070
pnpm add https://pkg.pr.new/mermaid-js/mermaid/@mermaid-js/parser@6070

commit: b7f7437

Copy link

codecov bot commented Nov 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 4.49%. Comparing base (8328f74) to head (b7f7437).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           develop   #6070   +/-   ##
=======================================
  Coverage     4.49%   4.49%           
=======================================
  Files          382     382           
  Lines        53914   53914           
  Branches       621     621           
=======================================
  Hits          2425    2425           
  Misses       51489   51489           
Flag Coverage Δ
unit 4.49% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

---- 🚨 Try these New Features:

@jgreywolf
Copy link
Contributor

Can you help me understand the intent and reasoning behind this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants