Fix: edge case causing extreme height in Architecture Diagrams

[NicolasNewman]

📑 Summary

Fix for edge cases in Architecture diagrams where the height would grow to extreme lengths

Resolves #5952

📏 Design Decisions

• getAlignments() now handles cases where nodes within two different groups connected along the x/y access cannot be aligned on the y/x axis.

Before:

After:

📋 Tasks

Make sure you

• 📖 have read the contribution guidelines
• 💻 have added necessary unit/e2e tests.
• 📓 have added documentation. Make sure MERMAID_RELEASE_VERSION is used for all new features.
• 🦋 If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

[changeset-bot]

🦋 Changeset detected

Latest commit: 2a91849

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
mermaid	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[netlify]

✅ Deploy Preview for mermaid-js ready!

Name	Link
🔨 Latest commit	2a91849
🔍 Latest deploy log	https://app.netlify.com/sites/mermaid-js/deploys/6738c30e9b5fa70008bf0753
😎 Deploy Preview	https://deploy-preview-6064--mermaid-js.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[pkg-pr-new]

Open in Stackblitz

pnpm add https://pkg.pr.new/mermaid-js/mermaid@6064

pnpm add https://pkg.pr.new/mermaid-js/mermaid/@mermaid-js/mermaid-zenuml@6064

pnpm add https://pkg.pr.new/mermaid-js/mermaid/@mermaid-js/parser@6064

pnpm add https://pkg.pr.new/mermaid-js/mermaid/@mermaid-js/layout-elk@6064

commit: 2a91849

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 141 lines in your changes missing coverage. Please review.

Project coverage is 4.48%. Comparing base (8328f74) to head (2a91849).

Files with missing lines	Patch %	Lines
.../src/diagrams/architecture/architectureRenderer.ts	0.00%	85 Missing ⚠️
...aid/src/diagrams/architecture/architectureTypes.ts	0.00%	32 Missing ⚠️
...ermaid/src/diagrams/architecture/architectureDb.ts	0.00%	24 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           develop   #6064      +/-   ##
==========================================
- Coverage     4.49%   4.48%   -0.02%     
==========================================
  Files          382     383       +1     
  Lines        53914   54048     +134     
  Branches       621     596      -25     
==========================================
  Hits          2425    2425              
- Misses       51489   51623     +134     

Flag	Coverage Δ
unit	4.48% <0.00%> (-0.02%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
...ermaid/src/diagrams/architecture/architectureDb.ts	0.00% <0.00%> (ø)
...aid/src/diagrams/architecture/architectureTypes.ts	0.00% <0.00%> (ø)
.../src/diagrams/architecture/architectureRenderer.ts	0.00% <0.00%> (ø)

... and 1 file with indirect coverage changes

[argos-ci]

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build	Status	Details	Updated (UTC)
default (Inspect)	✅ No changes detected	-	Nov 16, 2024, 4:15 PM