You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I am currently working on converting state diagram to Excalidraw, and I felt the need to have an easier way to find the edges.
I tried some alternative paths but without success, for example:
Manually tracking each edge, and using it as an index to search in .edgePaths, however, the index does not always reflect how we iterate through the parser.doc.
Using the respective graphCount id to get the edge, but in cases where we have multiple relationships for the same state, it may not find the correct edge because we do not have access to the graphCount in the parser.doc, only to the node id.
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📑 Summary
This PR reintroduces FROM-TO id in Edges.
#5503
📏 Design Decisions
I am currently working on converting state diagram to Excalidraw, and I felt the need to have an easier way to find the edges.
I tried some alternative paths but without success, for example:
.edgePaths
, however, the index does not always reflect how we iterate through the parser.doc.graphCount
id to get the edge, but in cases where we have multiple relationships for the same state, it may not find the correct edge because we do not have access to thegraphCount
in the parser.doc, only to the node id.📋 Tasks
Make sure you
MERMAID_RELEASE_VERSION
is used for all new features.develop
branch