Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Clusters break diagram when using elk layout #6028

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

yari-dewalt
Copy link
Collaborator

📑 Summary

Fixes cluster nodes from breaking the diagram if rendered using elk.

Resolves #6027

📏 Design Decisions

Removes true from being passed in to labelHelper() which was being treated as the shapeSvg resulting in shapeSvg.insert() is not a function error.

📋 Tasks

Make sure you

  • 📖 have read the contribution guidelines
  • 💻 have added necessary unit/e2e tests.
  • 📓 have added documentation. Make sure MERMAID_RELEASE_VERSION is used for all new features.
  • 🦋 If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Copy link

changeset-bot bot commented Nov 6, 2024

⚠️ No Changeset found

Latest commit: 616f8eb

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the Type: Bug / Error Something isn't working or is incorrect label Nov 6, 2024
Copy link

netlify bot commented Nov 6, 2024

Deploy Preview for mermaid-js ready!

Name Link
🔨 Latest commit 616f8eb
🔍 Latest deploy log https://app.netlify.com/sites/mermaid-js/deploys/672bb43bc37a1800084fca71
😎 Deploy Preview https://deploy-preview-6028--mermaid-js.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

pkg-pr-new bot commented Nov 6, 2024

Open in Stackblitz

pnpm add https://pkg.pr.new/mermaid-js/mermaid@6028
pnpm add https://pkg.pr.new/mermaid-js/mermaid/@mermaid-js/mermaid-zenuml@6028
pnpm add https://pkg.pr.new/mermaid-js/mermaid/@mermaid-js/layout-elk@6028
pnpm add https://pkg.pr.new/mermaid-js/mermaid/@mermaid-js/parser@6028

commit: 616f8eb

@yari-dewalt
Copy link
Collaborator Author

Should also fix e2e tests that fail due to this issue.

Copy link

argos-ci bot commented Nov 6, 2024

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
default (Inspect) ⚠️ Changes detected (Review) 340 added, 339 removed Nov 6, 2024, 6:32 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug / Error Something isn't working or is incorrect
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Using layout: elk on a diagram that uses clusters breaks the diagram
1 participant