-
-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix note non html text #6006
Fix note non html text #6006
Conversation
|
✅ Deploy Preview for mermaid-js ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
commit: |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #6006 +/- ##
==========================================
- Coverage 4.50% 4.50% -0.01%
==========================================
Files 383 383
Lines 53873 53875 +2
Branches 622 622
==========================================
Hits 2425 2425
- Misses 51448 51450 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
|
📑 Summary
Fixes notes (note shape) from displaying non-html rendered text incorrectly. The text is now properly centered and
useHtmlLabels
now uses theconfig.useHtmlLabels
value instead of the hard codedconfig.flowchart.useHtmlLabels
value as it is a better fit in this case. Also included is a similar change to labelHelper() to useconfig.useHtmlLabels
instead of the flowchart's value. And included a special case for ' characters in markdownToLines() so it doesn't get sanitized into the html character code value as that is common in notes.📏 Design Decisions
config.useHtmlLabels
is more appropriate thanconfig.flowchart.useHtmlLabels
in regards to the changes made here and it shouldn't cause any issues, but not fully sure.📋 Tasks
Make sure you
MERMAID_RELEASE_VERSION
is used for all new features.pnpm changeset
and following the prompts. Changesets that add features should beminor
and those that fix bugs should bepatch
. Please prefix changeset messages withfeat:
,fix:
, orchore:
.