Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Architecture Diagram grows very tall #5952

Open
Carus11 opened this issue Oct 10, 2024 · 1 comment · May be fixed by #6064
Open

Architecture Diagram grows very tall #5952

Carus11 opened this issue Oct 10, 2024 · 1 comment · May be fixed by #6064
Assignees
@NicolasNewman
Labels
Status: Triage Needs to be verified, categorized, etc Type: Bug / Error Something isn't working or is incorrect

Comments

@Carus11
Copy link

Carus11 commented Oct 10, 2024

Description

I have an architecture diagram with two groups, and in one group a bunch of nodes/database objects which I want to link to a particular service. I have done this through junctions but notice that when I create an edge connecting the two groups I then can cause the diagram to grow to a very tall size. If I leave the two groups disconnected it seem reasonable.

image

Steps to reproduce

In the code sample try removing and adding the line:

edge:R -- L:firewall

Screenshots

No response

Code Sample

https://develop.git.mermaid.live/edit#pako:eNqFlcGOgjAQhl-l6UkTPQjqgeNmNXvQbKJ7E7MpdMDuSmtKcWOM774FrIVQhUtp55_5_g6hveJYUMABJjI-MAWxKiSMI1Ak5Eg_qRTFCSVAQRIFdBAfRUGHu6VZQAt-ZlLwDLja1ynlk4M8sxiqEeRkUI_D3faSK8j2iHFbs5sFNIVHykJP0DuUgVd5mhJs0HiMVkGZHvKmf8G_TxIy4_6jiBxeEybhjxyPD_LyvtCk3ys926ndaDW6UwzI-K1zjONmURpNBpQoEpEchjs9e-2BRl5L7vXJ_Zbc75NPW_Jpn3zWks_65POWfN6W24SfgseKCY4yRp9WBBm8lc39CrTKmT1ZQaJE8qyIDZuvVBVyhO8c_XGcHO81x-twbGmn6oHznDj_Nc7v4DwHznfgfHcXNyw9qM9k_YTX3JeVNvpoFy1qauOuhvYgmyXNHl1oz4WedcGuJvdY8LoWfJcF32Vhjiy5lpbnmaljzo4ygkc4A5kRRvX5fS1XQqwOkEGIA_1KifwNcchvWkcKJbYXHuNAyQJGWJ-K6QEHCTnmelac9J8H74ykkmRGApQpIdf17VBdErd_TZnrJg

Setup

  • Mermaid version: Mermaidv11.3.0+f859772 (From live editor)
  • Browser and Version: Edge 129.0.2792.79 , Firefox v131

Suggested Solutions

No response

Additional Context

If I re-arrange the whole thing in a right to left orientation it seems to work
@Carus11 Carus11 added Status: Triage Needs to be verified, categorized, etc Type: Bug / Error Something isn't working or is incorrect labels Oct 10, 2024
@NicolasNewman NicolasNewman self-assigned this Nov 1, 2024
@NicolasNewman
Copy link
Collaborator

Thanks for bringing this up! I've identified the cause and will hopefully have a fix out by the end of this coming week.

NicolasNewman added a commit to NicolasNewman/mermaid that referenced this issue Nov 15, 2024
@NicolasNewman
fix(mermaid-js#5952): initial fix for architecture diagrams with extr…
cb0a470 
…eme heights
NicolasNewman added a commit to NicolasNewman/mermaid that referenced this issue Nov 15, 2024
@NicolasNewman
fix(mermaid-js#5952): handled additional edge cases
885ac6f
NicolasNewman added a commit to NicolasNewman/mermaid that referenced this issue Nov 15, 2024
@NicolasNewman
cicd(mermaid-js#5952): added test case for diagram that instigated th…
570ae78 
…e issue
NicolasNewman added a commit to NicolasNewman/mermaid that referenced this issue Nov 16, 2024
@NicolasNewman
chore(mermaid-js#5952): changeset
2a91849
@NicolasNewman NicolasNewman linked a pull request Nov 16, 2024 that will close this issue
Open
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@NicolasNewman NicolasNewman

Labels
Status: Triage Needs to be verified, categorized, etc Type: Bug / Error Something isn't working or is incorrect
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix: edge case causing extreme height in Architecture Diagrams NicolasNewman/mermaid
2 participants
@Carus11 @NicolasNewman