🌟feat(responseTrailers): support for response header trailers added #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plus GRPC_HEADER_METADATA_KEY_ID to config Grpc-Metadata headers key
|
will update the tests over the weekend |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please read the CLA carefully before submitting your contribution to Mercari.
Under any circumstances, by submitting your contribution, you are deemed to accept and agree to be bound by the terms and conditions of the CLA.
https://www.mercari.com/cla/
WHAT
Update allowing to receive back headers from the grpc call processing result.
plus ability to specify Grpc-Metadata- header key for incoming headers using an environment variable instead of constant value.
plus small updates to names as it was confusing to read the code a bit.
WHY
While translation is working great which is awesome! But the biggest issue for us when we were assessing the concept with your repo was the fact that we were not receiving any headers back from the rpc call result. Obviously the header trailers should be returned back to the caller, as they might contain new/updated data that client requires back.