added possibility to notify to ms-teams #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This feature looks good for me, thank you for your contribution. Could you continue the change that adding tests and documentation? I'll review it. cc/ @b4b4r07 |
s4ichi
reviewed
May 16, 2019
|
@s4ichi np, I resolved and committed the changes ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHAT
This pr Closes: #4 and adds support for MS Teams.
WHY
It's a very useful utility, and we can make use of it in MS Teams as well.
Important: I opened this for discussion, if you are interested in this as well, I will add Unit Tests and documentation.
I emulated the design of Slack implementation:
