Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add shim for sly #503

Merged
merged 1 commit into from
Sep 16, 2023
Merged

Add shim for sly #503

merged 1 commit into from
Sep 16, 2023

Conversation

jgarte
Copy link
Contributor

@jgarte jgarte commented Sep 6, 2023

Hi,

This adds a shim for the sly debugger.

For use in the following type of buffer on the left:

image

@jgarte
Copy link
Contributor Author

jgarte commented Sep 6, 2023

I just noticed that I need to do the same thing for sly-stickers-shortcut-mode.

How do you suggest I structure that?

@DogLooksGood
Copy link
Collaborator

I'm not familiar with sly, but I would like to have the PR.

@jgarte
Copy link
Contributor Author

jgarte commented Sep 6, 2023

This package which I use in conjunction with sly, will also need a shim for its macrostep mode:

https://github.com/joaotavora/sly-macrostep

I just tested it and meow gets in the way.

@DogLooksGood
Copy link
Collaborator

I saw there's only the code or sly itself, do you have more commits before we merge it?

@jgarte
Copy link
Contributor Author

jgarte commented Sep 6, 2023

I saw there's only the code or sly itself, do you have more commits before we merge it?

What I have here currently works only for the debugger restart window. I think what is currently here is useful but not comprehensive.

I'm not sure at the moment how to structure the code to cover all the other sly modes where we might want to also do the shim code.

Any thoughts?

@DogLooksGood
Copy link
Collaborator

It's not likely we need shim code for all the modes. For a major mode derived from special-mode, motion state will be used by default. The same to all text editing major modes.

The only case we have to handle is when we need a mode switch between normal/motion state due to some special minor mode.

@jgarte
Copy link
Contributor Author

jgarte commented Sep 6, 2023

It's not likely we need shim code for all the modes. For a major mode derived from special-mode, motion state will be used by default. The same to all text editing major modes.

The only case we have to handle is when we need a mode switch between normal/motion state due to some special minor mode.

@DogLooksGood Is there an existing example of what you are describing that I can follow?

@DogLooksGood
Copy link
Collaborator

I mean, for most major modes, you don't need any shim code.

@DogLooksGood
Copy link
Collaborator

Do you think this PR is ready for merge?

@jgarte
Copy link
Contributor Author

jgarte commented Sep 16, 2023

Do you think this PR is ready for merge?

Hi,

It works for the sly debugger restart view. It does not cover all of sly though.

I think it is ready to merge at least for the sly debugger restart menu.

Might be a while before I am able to work on the other parts of sly and scope what else is needed for that.

@DogLooksGood DogLooksGood merged commit ba0cf4d into meow-edit:master Sep 16, 2023
3 checks passed
@jgarte jgarte deleted the sly branch September 16, 2023 17:02
@jgarte
Copy link
Contributor Author

jgarte commented Sep 16, 2023

Hi,

When do you think that this change will land in nongnu ELPA?

Just asking because then I can remove it from my Emacsaroni 🍜

https://git.sr.ht/~whereiseveryone/emacsaroni/tree/master/item/site-lisp/meow-sly-shim.el

@DogLooksGood
Copy link
Collaborator

it seems that we have to cut a release to make it updated?

@jgarte
Copy link
Contributor Author

jgarte commented Sep 17, 2023

Yep, a release party 🎉 ;()

@okamsn okamsn mentioned this pull request Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants