-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add shim for sly #503
Add shim for sly #503
Conversation
I just noticed that I need to do the same thing for How do you suggest I structure that? |
I'm not familiar with sly, but I would like to have the PR. |
This package which I use in conjunction with sly, will also need a shim for its macrostep mode: https://github.com/joaotavora/sly-macrostep I just tested it and meow gets in the way. |
I saw there's only the code or |
What I have here currently works only for the debugger restart window. I think what is currently here is useful but not comprehensive. I'm not sure at the moment how to structure the code to cover all the other sly modes where we might want to also do the shim code. Any thoughts? |
It's not likely we need shim code for all the modes. For a major mode derived from The only case we have to handle is when we need a mode switch between normal/motion state due to some special minor mode. |
@DogLooksGood Is there an existing example of what you are describing that I can follow? |
I mean, for most major modes, you don't need any shim code. |
Do you think this PR is ready for merge? |
Hi, It works for the sly debugger restart view. It does not cover all of sly though. I think it is ready to merge at least for the sly debugger restart menu. Might be a while before I am able to work on the other parts of sly and scope what else is needed for that. |
Hi, When do you think that this change will land in nongnu ELPA? Just asking because then I can remove it from my Emacsaroni 🍜 https://git.sr.ht/~whereiseveryone/emacsaroni/tree/master/item/site-lisp/meow-sly-shim.el |
it seems that we have to cut a release to make it updated? |
Yep, a release party 🎉 ;() |
Hi,
This adds a shim for the sly debugger.
For use in the following type of buffer on the left: