Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(webhook): Inventory webhook description. #2470

Conversation

merlin-northern
Copy link
Contributor

Changelog: Title
Ticket: MEN-7450

@merlin-northern
Copy link
Contributor Author

@estenberg this is more fyi Eystein, we will have to adjust the existing screenshots later.

@merlin-northern merlin-northern force-pushed the men_7450__docs_update_docs_with_webhook_types_and_describe_both_old_and_new_types_ branch 2 times, most recently from d5db8d3 to 1717b89 Compare October 4, 2024 09:15
Copy link
Member

@MuchoLucho MuchoLucho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have not tested the steps but it looks reasonable to me

@merlin-northern merlin-northern force-pushed the men_7450__docs_update_docs_with_webhook_types_and_describe_both_old_and_new_types_ branch 2 times, most recently from 5bf2d6c to a1f7ddf Compare October 4, 2024 09:21
Copy link
Member

@nickanderson nickanderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Take or leave suggestions for re-phrasing.

Comment on lines 8 to 10
to notify external applications about device lifecycle and inventory changed events. This helps
you avoid polling and manual synchronization between Mender and other systems, as well as allows
you to handle device-related events and integrate Mender into your ecosystem seamlessly.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
to notify external applications about device lifecycle and inventory changed events. This helps
you avoid polling and manual synchronization between Mender and other systems, as well as allows
you to handle device-related events and integrate Mender into your ecosystem seamlessly.
to notify external applications about device lifecycle and inventory changed events. This eliminates the need for manual polling and synchronization, allowing for efficient handling of device-related events.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed. I only could not resist and added extra sentence about integration.


This integration is available in all Mender plans, as well as Mender Open Source.
We divided webhook integrations into two categories (_scopes_): `deviceauth` and `inventory`.
The former is available in all Mender plans, as well as Mender Open Source,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I want to suggest a link to mender plans here when mentioned. I dunno how stable that url is. https://mender.io/pricing/plans

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure.

Comment on lines 24 to 27
You need an external service or application exposed on the internet and able to receive data
from Mender in the form of an HTTP POST request. The hostname part of the URL must resolve
to a globally routable unicast IP address. We recommend using HTTPS and configuring
a secret for request signing purposes (see [below](#signature-header)).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
You need an external service or application exposed on the internet and able to receive data
from Mender in the form of an HTTP POST request. The hostname part of the URL must resolve
to a globally routable unicast IP address. We recommend using HTTPS and configuring
a secret for request signing purposes (see [below](#signature-header)).
To receive data from Mender, you'll need an internet-accessible service or app that can accept HTTP POST requests. The service's domain name should resolve to a publicly accessible IP address. For security, we recommend using HTTPS and setting up a secret for verifying request authenticity (see [below](#signature-header)).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed. I just added unicast. I like that word. Unicast.

* device provisioning,
* device decommissioning, or
* its authentication status changes.

### Inventory changed triggers

A webhook in the `inventory` scope fires when device changed inventory events:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
A webhook in the `inventory` scope fires when device changed inventory events:
A webhook in the `inventory` scope fires whenever Mender Server detects and updates a change in a device's inventory information.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed.

### Inventory changed triggers

A webhook in the `inventory` scope fires when device changed inventory events:
* Mender Server detected a change in the device inventory and updated it in the db
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* Mender Server detected a change in the device inventory and updated it in the db

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed.


If you specify a secret, an integrity check is calculated and located in the `X-Men-Signature` header, which contains the HMAC-SHA256 of the payload using the configured secret.
If you specify a secret, an integrity check is calculated and located in the `X-Men-Signature` header,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why X-Men? Could be Avengers, Fantastic Four, Justice League, Teen Titans.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

haha! a. I like XMen second: can we make it Spiderman?

Changelog: Title
Ticket: MEN-7450
Signed-off-by: Peter Grzybowski <[email protected]>
@merlin-northern merlin-northern force-pushed the men_7450__docs_update_docs_with_webhook_types_and_describe_both_old_and_new_types_ branch from a1f7ddf to 34e18c2 Compare October 4, 2024 14:44
@mender-test-bot
Copy link

mender-test-bot commented Oct 4, 2024

Merging these commits will result in the following changelog entries:

Changelogs

mender-docs (men_7450__docs_update_docs_with_webhook_types_and_describe_both_old_and_new_types_)

New changes in mender-docs since master:

  • Inventory webhook description.
    (MEN-7450)

@merlin-northern merlin-northern merged commit 0f7549d into mendersoftware:master Oct 4, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants