-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature - Support Azure AI Search as a Vector DB #1967
Feature - Support Azure AI Search as a Vector DB #1967
Conversation
@Dev-Khant would you take a look please. |
Hey @maljazaery Can you please check why the tests are failing? |
56aebe7
to
770b9ad
Compare
dcbc0b2
to
1fb7ca1
Compare
@Dev-Khant, I fixed the package dependency issue. Now, I am showing an error message if the required python package is not installed. Thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please run make format
to properly format the code. And please can you add tests for this?
@Dev-Khant thank you for reviewing the code! I fixed all the issues. |
Hey @maljazaery Thanks for the quick resolution. Can you please also add the tests for this new vectordb? |
I checked the notebook and it looks good to me. Thanks @maljazaery for the contribution! |
[heart] Mohamad Al Jazaery reacted to your message:
…________________________________
From: Dev Khant ***@***.***>
Sent: Tuesday, October 29, 2024 4:42:59 PM
To: mem0ai/mem0 ***@***.***>
Cc: Mohamad Al Jazaery ***@***.***>; Mention ***@***.***>
Subject: Re: [mem0ai/mem0] Feature - Support Azure AI Search as a Vector DB (PR #1967)
I checked the notebook and it looks good to me. Thanks @maljazaery<https://github.com/maljazaery> for the contribution!
—
Reply to this email directly, view it on GitHub<#1967 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/BGDTC7M24MYEZSD4I2NHMEDZ563JHAVCNFSM6AAAAABQCP4FKCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINBUHAYTCOJWG4>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
Description
Support Azure AI Search as a vector DB.
Dependencies: azure-search-documents
Type of change
How Has This Been Tested?
Checklist:
Maintainer Checklist