Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature - Support Azure AI Search as a Vector DB #1967

Merged
merged 4 commits into from
Oct 29, 2024

Conversation

maljazaery
Copy link
Contributor

@maljazaery maljazaery commented Oct 16, 2024

Description

Support Azure AI Search as a vector DB.
Dependencies: azure-search-documents

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

  • Test Script (please provide)
from mem0 import Memory
config = {
    "vector_store": {
        "provider": "azure_ai_search",
        "config": {
            "service_name": "xxxx",
            "api_key": "xxx",
            "embedding_model_dims": 1536 ,
        }
    }
}


m = Memory.from_config(config)
m.add("Likes to play cricket on weekends", user_id="alice", metadata={"category": "hobbies"})

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • [] I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • [] Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

Maintainer Checklist

  • closes #xxxx (Replace xxxx with the GitHub issue number)
  • Made sure Checks passed

@CLAassistant
Copy link

CLAassistant commented Oct 16, 2024

CLA assistant check
All committers have signed the CLA.

@maljazaery
Copy link
Contributor Author

@Dev-Khant would you take a look please.

@Dev-Khant
Copy link
Member

Hey @maljazaery Can you please check why the tests are failing?

@maljazaery maljazaery force-pushed the feature_azure_ai_search_vector_db branch from 56aebe7 to 770b9ad Compare October 21, 2024 17:57
@maljazaery maljazaery force-pushed the feature_azure_ai_search_vector_db branch from dcbc0b2 to 1fb7ca1 Compare October 22, 2024 22:56
@maljazaery
Copy link
Contributor Author

@Dev-Khant, I fixed the package dependency issue. Now, I am showing an error message if the required python package is not installed. Thanks

Copy link
Member

@Dev-Khant Dev-Khant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please run make format to properly format the code. And please can you add tests for this?

@maljazaery
Copy link
Contributor Author

@Dev-Khant thank you for reviewing the code! I fixed all the issues.

@Dev-Khant
Copy link
Member

Hey @maljazaery Thanks for the quick resolution. Can you please also add the tests for this new vectordb?

@maljazaery
Copy link
Contributor Author

@Dev-Khant
Copy link
Member

I checked the notebook and it looks good to me. Thanks @maljazaery for the contribution!

@Dev-Khant Dev-Khant merged commit 61a24f0 into mem0ai:main Oct 29, 2024
5 checks passed
@maljazaery
Copy link
Contributor Author

maljazaery commented Oct 29, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants