Skip to content

Commit

Permalink
Fix gdbstub not activating until the console is reset (#2245)
Browse files Browse the repository at this point in the history
The check for initialising the gdbstub depending on whether the JIT was
enabled or not was the wrong way around: previously, it would only
enable the gdbstub if the JIT was enabled.

The stub started working again if you reset the console, as
NDS::SetGdbArgs didn't have any such check and it was called by
EmuInstance::updateConsole.
  • Loading branch information
ZNixian authored Dec 23, 2024
1 parent 7d718ad commit 72c86ad
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/ARM.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,7 @@ ARM::ARM(u32 num, bool jit, std::optional<GDBArgs> gdb, melonDS::NDS& nds) :
Num(num), // well uh
NDS(nds)
{
SetGdbArgs(jit ? gdb : std::nullopt);
SetGdbArgs(jit ? std::nullopt : gdb);
}

ARM::~ARM()
Expand Down

0 comments on commit 72c86ad

Please sign in to comment.