-
-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: uncurry 0 #949
base: main
Are you sure you want to change the base?
feat: uncurry 0 #949
Conversation
861d78a
to
09523f3
Compare
09523f3
to
3f743e2
Compare
@jchavarri @andreypopp this is now ready for review. Note the comment (#674 (comment)) where I highlighted we're not handling Let me know your thoughts! |
|
||
let pp fmt t = | ||
match t with | ||
| Unused_attribute s -> | ||
Format.fprintf fmt | ||
"Unused attribute [%@%s]@\n\ | ||
This means such annotation is not annotated properly.@\n\ | ||
For example, some annotations are only meaningful in externals\n" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why removing the newline here? I found it was useful to have it (see changes in tests).
Edit: I see other messages don't include it. Maybe the newline could be added separately to have some space between the alert and the actual output when calling melc
?
d6af25b
to
033f846
Compare
This should be ready to merge, but there are a few issues with the PR in the current state:
|
just for doc purposes, found this issue: reasonml/reason#2357 |
fixes #674